Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Gustavo Sousa <gustavo.sousa@intel.com>
To: Dnyaneshwar Bhadane <dnyaneshwar.bhadane@intel.com>,
	<intel-xe@lists.freedesktop.org>
Cc: Matt Atwood <matthew.s.atwood@intel.com>,
	Dnyaneshwar Bhadane <dnyaneshwar.bhadane@intel.com>,
	Matt Roper <matthew.d.roper@intel.com>
Subject: Re: [PATCH v2 4/9] drm/i915/xe3lpd: Update bandwidth parameters for display version 30.02
Date: Mon, 9 Jun 2025 14:13:37 -0300	[thread overview]
Message-ID: <174948921780.2052.12545268320202523972@intel.com> (raw)
In-Reply-To: <20250606195104.1771715-5-dnyaneshwar.bhadane@intel.com>

When sending a new version of a series, I think it would be good to have
all patches of the sames series tagged with the same version number
(i.e. [PATCH v<n>]), even if not all of them have updates.

By marking only some patches with the version, tools get confused. For
example, I'm unable to easily apply the full series to my local tree
with b4 shazam, as it tells me the series is incomplete.

More importantly, I'm not exactly sure how Patchwork (which I believe is
what ends up triggering CI) behaves in these situations.

--
Gustavo Sousa

Quoting Dnyaneshwar Bhadane (2025-06-06 16:50:59-03:00)
>From: Matt Atwood <matthew.s.atwood@intel.com>
>
>Bandwidth parameters for WCL have been updated with respect to
>previous display releases. Encode them into xe3lpd_3002_sa_info and use
>that new struct.
>
>-v2: Resolve conflict on applying patche.
>
>Bspec: 68859
>Signed-off-by: Matt Atwood <matthew.s.atwood@intel.com>
>Signed-off-by: Dnyaneshwar Bhadane <dnyaneshwar.bhadane@intel.com>
>Reviewed-by: Matt Roper <matthew.d.roper@intel.com>
>---
> drivers/gpu/drm/i915/display/intel_bw.c | 11 ++++++++++-
> 1 file changed, 10 insertions(+), 1 deletion(-)
>
>diff --git a/drivers/gpu/drm/i915/display/intel_bw.c b/drivers/gpu/drm/i915/display/intel_bw.c
>index 97aef729f7d4..6175081d41a8 100644
>--- a/drivers/gpu/drm/i915/display/intel_bw.c
>+++ b/drivers/gpu/drm/i915/display/intel_bw.c
>@@ -418,6 +418,13 @@ static const struct intel_sa_info xe3lpd_sa_info = {
>         .derating = 10,
> };
> 
>+static const struct intel_sa_info xe3lpd_3002_sa_info = {
>+        .deburst = 32,
>+        .deprogbwlimit = 22, /* GB/s */
>+        .displayrtids = 256,
>+        .derating = 10,
>+};
>+
> static int icl_get_bw_info(struct intel_display *display,
>                            const struct dram_info *dram_info,
>                            const struct intel_sa_info *sa)
>@@ -769,7 +776,9 @@ void intel_bw_init_hw(struct intel_display *display)
>         if (!HAS_DISPLAY(display))
>                 return;
> 
>-        if (DISPLAY_VER(display) >= 30)
>+        if (DISPLAY_VERx100(display) >= 3002)
>+                tgl_get_bw_info(display, dram_info, &xe3lpd_3002_sa_info);
>+        else if (DISPLAY_VER(display) >= 30)
>                 tgl_get_bw_info(display, dram_info, &xe3lpd_sa_info);
>         else if (DISPLAY_VERx100(display) >= 1401 && display->platform.dgfx &&
>                  dram_info->type == INTEL_DRAM_GDDR_ECC)
>-- 
>2.34.1
>

  reply	other threads:[~2025-06-09 17:13 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-06 19:50 [PATCH 0/9] Add WildCat Lake support Dnyaneshwar Bhadane
2025-06-06 19:50 ` [PATCH 1/9] drm/i915/xe3lpd: Add support for display version 30.02 Dnyaneshwar Bhadane
2025-06-09 14:36   ` Matt Roper
2025-06-06 19:50 ` [PATCH 2/9] drm/xe/xe3: Add support for graphics IP version 30.03 Dnyaneshwar Bhadane
2025-06-09  7:00   ` Vivekanandan, Balasubramani
2025-06-11 14:31     ` Bhadane, Dnyaneshwar
2025-06-06 19:50 ` [PATCH 3/9] drm/xe/xe3: Add support for media IP version 30.02 Dnyaneshwar Bhadane
2025-06-09  7:11   ` Vivekanandan, Balasubramani
2025-06-06 19:50 ` [PATCH v2 4/9] drm/i915/xe3lpd: Update bandwidth parameters for display " Dnyaneshwar Bhadane
2025-06-09 17:13   ` Gustavo Sousa [this message]
2025-06-06 19:51 ` [PATCH 5/9] drm/i915: Set max cdclk for display 30.02 Dnyaneshwar Bhadane
2025-06-06 19:51 ` [PATCH 6/9] drm/xe: Add Wildcat Lake device IDs to PTL list Dnyaneshwar Bhadane
2025-06-06 19:51 ` [PATCH 7/9] drm/i915/xe3lpd: Extend DMC path for display version 30.02 Dnyaneshwar Bhadane
2025-06-06 19:51 ` [PATCH 8/9] drm/i915/wcl: C10 phy connected to port A and B Dnyaneshwar Bhadane
2025-06-09 15:05   ` Matt Roper
2025-06-10 13:49     ` Bhadane, Dnyaneshwar
2025-06-10 15:13       ` Matt Roper
2025-06-10 16:31         ` Taylor, Clinton A
2025-06-10 16:53           ` Matt Roper
2025-06-16 16:45             ` Bhadane, Dnyaneshwar
2025-06-06 19:51 ` [PATCH 9/9] drm/i915/xe3lpd: Extend WA 16023981245 for display 30.02 Dnyaneshwar Bhadane
2025-06-09  6:53   ` Pottumuttu, Sai Teja
2025-06-09  7:18   ` Vivekanandan, Balasubramani
2025-06-09  8:21     ` Bhadane, Dnyaneshwar
2025-06-09 15:09       ` Matt Roper
2025-06-09 16:01         ` Bhadane, Dnyaneshwar
2025-06-06 20:27 ` ✓ CI.Patch_applied: success for Add WildCat Lake support (rev3) Patchwork
2025-06-06 20:28 ` ✓ CI.checkpatch: " Patchwork
2025-06-06 20:29 ` ✓ CI.KUnit: " Patchwork
2025-06-06 20:39 ` ✓ CI.Build: " Patchwork
2025-06-06 20:42 ` ✓ CI.Hooks: " Patchwork
2025-06-06 20:44 ` ✗ CI.checksparse: warning " Patchwork
2025-06-06 21:28 ` ✓ Xe.CI.BAT: success " Patchwork
2025-06-09  4:15 ` ✗ Xe.CI.Full: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=174948921780.2052.12545268320202523972@intel.com \
    --to=gustavo.sousa@intel.com \
    --cc=dnyaneshwar.bhadane@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=matthew.d.roper@intel.com \
    --cc=matthew.s.atwood@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox