From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
To: Ashutosh Dixit <ashutosh.dixit@intel.com>,
intel-xe@lists.freedesktop.org
Cc: "Brost, Matthew" <matthew.brost@intel.com>
Subject: Re: [CI] drm/xe: Replace xe_device_wmb by wmb
Date: Tue, 27 Aug 2024 12:03:13 +0200 [thread overview]
Message-ID: <175bd1a4-41e1-445d-ad56-c47d785d7ab1@linux.intel.com> (raw)
In-Reply-To: <20240826234100.1850471-1-ashutosh.dixit@intel.com>
Hey,
Den 2024-08-27 kl. 01:41, skrev Ashutosh Dixit:
> CI ONLY for now
>
> In xe_device_wmb(), it is not clear what the purpose of register write
> following wmb() is. Replace xe_device_wmb() with just wmb() to see if we
> see any failures in CI.
>
> Signed-off-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
After doing some digging, I came across it was originally added by brost:
"drm/xe: Add wmb after updating page tables with CPU
wmb is a MMIO write on VRAM devices."
I think removing it would break discrete graphics as internal caches need to be flushed.
CC´d Brost to be sure.
Cheers,
Maarten
prev parent reply other threads:[~2024-08-27 10:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-26 23:41 [CI] drm/xe: Replace xe_device_wmb by wmb Ashutosh Dixit
2024-08-27 0:58 ` ✓ CI.Patch_applied: success for " Patchwork
2024-08-27 0:58 ` ✗ CI.checkpatch: warning " Patchwork
2024-08-27 0:59 ` ✓ CI.KUnit: success " Patchwork
2024-08-27 1:12 ` ✓ CI.Build: " Patchwork
2024-08-27 1:15 ` ✓ CI.Hooks: " Patchwork
2024-08-27 1:18 ` ✓ CI.checksparse: " Patchwork
2024-08-27 1:37 ` ✓ CI.BAT: " Patchwork
2024-08-27 3:03 ` [CI] " Matthew Brost
2024-08-27 22:25 ` Dixit, Ashutosh
2024-08-27 9:49 ` ✗ CI.FULL: failure for " Patchwork
2024-08-27 10:03 ` Maarten Lankhorst [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=175bd1a4-41e1-445d-ad56-c47d785d7ab1@linux.intel.com \
--to=maarten.lankhorst@linux.intel.com \
--cc=ashutosh.dixit@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=matthew.brost@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox