From: Patchwork <patchwork@emeril.freedesktop.org>
To: "Matthew Brost" <matthew.brost@intel.com>
Cc: intel-xe@lists.freedesktop.org
Subject: ✗ CI.checkpatch: warning for Different page size handle in migrate layer
Date: Mon, 13 Oct 2025 02:02:36 -0000 [thread overview]
Message-ID: <176032095691.3591.852794766155776296@97596180aaec> (raw)
In-Reply-To: <20251013015620.4115242-1-matthew.brost@intel.com>
== Series Details ==
Series: Different page size handle in migrate layer
URL : https://patchwork.freedesktop.org/series/155794/
State : warning
== Summary ==
+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
fbd08a78c3a3bb17964db2a326514c69c1dca660
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit cf63ebef4fac2ce8f2dbab32fb0ab7e43e6ab404
Author: Matthew Brost <matthew.brost@intel.com>
Date: Sun Oct 12 18:56:20 2025 -0700
drm/xe: Enable 2M pages in xe_migrate_vram
Using 2M pages in xe_migrate_vram has two benefits: we issue fewer
instructions per 2M copy (1 vs. 512), and the cache hit rate should be
higher. This results in increased copy engine bandwidth, as shown by
benchmark IGTs.
Enable 2M pages by reserving PDEs in the migrate VM and using 2M pages
in xe_migrate_vram if the DMA address order matches 2M.
v2:
- Reuse build_pt_update_batch_sram (Stuart)
- Fix build_pt_update_batch_sram for PAGE_SIZE > 4K
v3:
- More fixes for PAGE_SIZE > 4K, align chunk, decrement chunk as needed
- Use stack incr var in xe_migrate_vram_use_pde (Stuart)
v4:
- Split PAGE_SIZE > 4K fix out in different patch (Stuart)
Signed-off-by: Matthew Brost <matthew.brost@intel.com>
+ /mt/dim checkpatch 085518a4da5bcf9b68ef798e27ef71d64443aad7 drm-intel
8a4e2dccbc64 drm/xe: Fix build_pt_update_batch_sram for non-4K PAGE_SIZE
cf63ebef4fac drm/xe: Enable 2M pages in xe_migrate_vram
-:86: WARNING:ONE_SEMICOLON: Statements terminations use 1 semicolon
#86: FILE: drivers/gpu/drm/xe/xe_migrate.c:1845:
+ unsigned long i, incr = large_size / PAGE_SIZE;;
total: 0 errors, 1 warnings, 0 checks, 109 lines checked
next prev parent reply other threads:[~2025-10-13 2:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-13 1:56 [PATCH v4 0/2] Different page size handle in migrate layer Matthew Brost
2025-10-13 1:56 ` [PATCH v4 1/2] drm/xe: Fix build_pt_update_batch_sram for non-4K PAGE_SIZE Matthew Brost
2025-10-13 1:56 ` [PATCH v4 2/2] drm/xe: Enable 2M pages in xe_migrate_vram Matthew Brost
2025-10-13 2:02 ` Patchwork [this message]
2025-10-13 2:03 ` ✓ CI.KUnit: success for Different page size handle in migrate layer Patchwork
2025-10-13 2:50 ` ✓ Xe.CI.BAT: " Patchwork
2025-10-13 3:17 ` ✓ Xe.CI.Full: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=176032095691.3591.852794766155776296@97596180aaec \
--to=patchwork@emeril.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=matthew.brost@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox