Re: [PATCH] drm/i915/xe3lpd: Load DMC for xe3lpd 3002

[Gustavo Sousa <gustavo.sousa@intel.com>]

Quoting Dnyaneshwar Bhadane (2025-10-16 10:15:17-03:00)
>Load the DMC for Xe3LPD for display version 3002.
>

I think it would be better to use the dotted syntax for the IP version
in commit messages, i.e. 30.02. I'll reword the commit message and
apply.

Reviewed-by: Gustavo Sousa <gustavo.sousa@intel.com>

>Signed-off-by: Dnyaneshwar Bhadane <dnyaneshwar.bhadane@intel.com>
>---
> drivers/gpu/drm/i915/display/intel_dmc.c | 10 +++++++---
> 1 file changed, 7 insertions(+), 3 deletions(-)
>
>diff --git a/drivers/gpu/drm/i915/display/intel_dmc.c b/drivers/gpu/drm/i915/display/intel_dmc.c
>index 77a0199f9ea5..f3f10f97a573 100644
>--- a/drivers/gpu/drm/i915/display/intel_dmc.c
>+++ b/drivers/gpu/drm/i915/display/intel_dmc.c
>@@ -127,6 +127,9 @@ static bool dmc_firmware_param_disabled(struct intel_display *display)
> #define DISPLAY_VER13_DMC_MAX_FW_SIZE        0x20000
> #define DISPLAY_VER12_DMC_MAX_FW_SIZE        ICL_DMC_MAX_FW_SIZE
> 
>+#define XE3LPD_3002_DMC_PATH                DMC_PATH(xe3lpd_3002)
>+MODULE_FIRMWARE(XE3LPD_3002_DMC_PATH);
>+
> #define XE3LPD_DMC_PATH                        DMC_PATH(xe3lpd)
> MODULE_FIRMWARE(XE3LPD_DMC_PATH);
> 
>@@ -183,9 +186,10 @@ static const char *dmc_firmware_default(struct intel_display *display, u32 *size
> {
>         const char *fw_path = NULL;
>         u32 max_fw_size = 0;
>-
>-        if (DISPLAY_VERx100(display) == 3002 ||
>-            DISPLAY_VERx100(display) == 3000) {
>+        if (DISPLAY_VERx100(display) == 3002) {
>+                fw_path = XE3LPD_3002_DMC_PATH;
>+                max_fw_size = XE2LPD_DMC_MAX_FW_SIZE;
>+        } else if (DISPLAY_VERx100(display) == 3000) {
>                 fw_path = XE3LPD_DMC_PATH;
>                 max_fw_size = XE2LPD_DMC_MAX_FW_SIZE;
>         } else if (DISPLAY_VERx100(display) == 2000) {
>-- 
>2.51.0
>