Re: [PATCH] drm/xe/configfs: Drop MAX_GT_TYPE_CHARS constant

[Gustavo Sousa <gustavo.sousa@intel.com>]

Quoting Matt Roper (2025-10-24 17:08:35-03:00)
>Early revisions of commit 7abd69278bb5 ("drm/xe/configfs: Add attribute
>to disable GT types") used MAX_GT_TYPE_CHARS not only to size the
>constant name field, but also for some of the string matching logic.  By
>the time the patch finally landed, the constant was no longer needed for
>parsing.  Stop using it for the string field definition as well; this
>eliminates the risk that we forget to update the constant if we ever add
>a GT type name longer than seven characters.
>
>Suggested-by: Gustavo Sousa <gustavo.sousa@intel.com>
>Signed-off-by: Matt Roper <matthew.d.roper@intel.com>

Reviewed-by: Gustavo Sousa <gustavo.sousa@intel.com>

>---
> drivers/gpu/drm/xe/xe_configfs.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
>diff --git a/drivers/gpu/drm/xe/xe_configfs.c b/drivers/gpu/drm/xe/xe_configfs.c
>index c1419a270fa4..fad75650f3dd 100644
>--- a/drivers/gpu/drm/xe/xe_configfs.c
>+++ b/drivers/gpu/drm/xe/xe_configfs.c
>@@ -301,7 +301,6 @@ struct engine_info {
> /* Some helpful macros to aid on the sizing of buffer allocation when parsing */
> #define MAX_ENGINE_CLASS_CHARS 5
> #define MAX_ENGINE_INSTANCE_CHARS 2
>-#define MAX_GT_TYPE_CHARS 7
> 
> static const struct engine_info engine_info[] = {
>         { .cls = "rcs", .mask = XE_HW_ENGINE_RCS_MASK, .engine_class = XE_ENGINE_CLASS_RENDER },
>@@ -313,7 +312,7 @@ static const struct engine_info engine_info[] = {
> };
> 
> static const struct {
>-        const char name[MAX_GT_TYPE_CHARS + 1];
>+        const char *name;
>         enum xe_gt_type type;
> } gt_types[] = {
>         { .name = "primary", .type = XE_GT_TYPE_MAIN },
>-- 
>2.51.0
>