Re: [PATCH] drm/xe/kunit: Fix forcewake assertion in mocs test

[Gustavo Sousa <gustavo.sousa@intel.com>]

Quoting Matt Roper (2025-11-13 20:40:39-03:00)
>The MOCS kunit test calls KUNIT_ASSERT_TRUE_MSG() with a condition of
>'true;' this prevents the assertion from ever failing.  Replace
>KUNIT_ASSERT_TRUE_MSG with KUNIT_FAIL_AND_ABORT to get the intended
>failure behavior in cases where forcewake was not acquired successfully.
>
>Fixes: 51c0ee84e4dc ("drm/xe/tests/mocs: Hold XE_FORCEWAKE_ALL for LNCF regs")
>Cc: Tejas Upadhyay <tejas.upadhyay@intel.com>
>Cc: Gustavo Sousa <gustavo.sousa@intel.com>
>Signed-off-by: Matt Roper <matthew.d.roper@intel.com>

Reviewed-by: Gustavo Sousa <gustavo.sousa@intel.com>

>---
> drivers/gpu/drm/xe/tests/xe_mocs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/gpu/drm/xe/tests/xe_mocs.c b/drivers/gpu/drm/xe/tests/xe_mocs.c
>index 0e502feaca81..6bb278167aaf 100644
>--- a/drivers/gpu/drm/xe/tests/xe_mocs.c
>+++ b/drivers/gpu/drm/xe/tests/xe_mocs.c
>@@ -49,7 +49,7 @@ static void read_l3cc_table(struct xe_gt *gt,
>         fw_ref = xe_force_wake_get(gt_to_fw(gt), XE_FORCEWAKE_ALL);
>         if (!xe_force_wake_ref_has_domain(fw_ref, XE_FORCEWAKE_ALL)) {
>                 xe_force_wake_put(gt_to_fw(gt), fw_ref);
>-                KUNIT_ASSERT_TRUE_MSG(test, true, "Forcewake Failed.\n");
>+                KUNIT_FAIL_AND_ABORT(test, "Forcewake Failed.\n");
>         }
> 
>         for (i = 0; i < info->num_mocs_regs; i++) {
>-- 
>2.51.1
>