From: Patchwork <patchwork@emeril.freedesktop.org>
To: "Chaitanya Kumar Borah" <chaitanya.kumar.borah@intel.com>
Cc: intel-xe@lists.freedesktop.org
Subject: ✗ CI.checkpatch: warning for fs: PM: Fix reverse check in filesystems_freeze_callback() (rev2)
Date: Thu, 04 Dec 2025 13:59:52 -0000 [thread overview]
Message-ID: <176485679221.56921.181548856420925458@a3b018990fe9> (raw)
In-Reply-To: <20251203135551.2629298-1-chaitanya.kumar.borah@intel.com>
== Series Details ==
Series: fs: PM: Fix reverse check in filesystems_freeze_callback() (rev2)
URL : https://patchwork.freedesktop.org/series/158444/
State : warning
== Summary ==
+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
2de9a3901bc28757c7906b454717b64e2a214021
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 5146733288657dd18886b961b43837e19a194c58
Author: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Date: Wed Dec 3 19:25:51 2025 +0530
fs: PM: Fix reverse check in filesystems_freeze_callback()
The freeze_all_ptr check in filesystems_freeze_callback() introduced by
commit a3f8f8662771 ("power: always freeze efivarfs") is reverse which
quite confusingly causes all file systems to be frozen when
filesystem_freeze_enabled is false.
On my systems it causes the WARN_ON_ONCE() in __set_task_frozen() to
trigger, most likely due to an attempt to freeze a file system that is
not ready for that.
Add a logical negation to the check in question to reverse it as
appropriate.
Fixes: a3f8f8662771 ("power: always freeze efivarfs")
Cc: 6.18+ <stable@vger.kernel.org> # 6.18+
Link: https://lore.kernel.org/linux-pm/12788397.O9o76ZdvQC@rafael.j.wysocki/
References: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/15341
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Reviewed-by: Jan Kara <jack@suse.cz>
Signed-off-by: Chaitanya Kumar Borah <chaitanya.kumar.borah@intel.com>
Acked-by: Jani Nikula <jani.nikula@intel.com>
+ /mt/dim checkpatch b91a982bdeb8b2c13917d3726c86cfa57ff3202d drm-intel
514673328865 fs: PM: Fix reverse check in filesystems_freeze_callback()
-:19: WARNING:BAD_STABLE_ADDRESS_STYLE: Invalid email format for stable: '6.18+ <stable@vger.kernel.org> # 6.18+', prefer 'stable@vger.kernel.org # 6.18+'
#19:
Cc: 6.18+ <stable@vger.kernel.org> # 6.18+
-:21: WARNING:COMMIT_LOG_USE_LINK: Unknown link reference 'References:', use 'Link:' or 'Closes:' instead
#21:
References: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/15341
total: 0 errors, 2 warnings, 0 checks, 8 lines checked
next prev parent reply other threads:[~2025-12-04 13:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-03 13:55 [Core-for-CI] fs: PM: Fix reverse check in filesystems_freeze_callback() Chaitanya Kumar Borah
2025-12-03 14:18 ` ✗ CI.checkpatch: warning for " Patchwork
2025-12-03 14:19 ` ✓ CI.KUnit: success " Patchwork
2025-12-04 10:02 ` [Core-for-CI] " Jani Nikula
2025-12-04 13:59 ` Patchwork [this message]
2025-12-04 14:01 ` ✓ CI.KUnit: success for fs: PM: Fix reverse check in filesystems_freeze_callback() (rev2) Patchwork
2025-12-04 15:20 ` ✓ Xe.CI.BAT: " Patchwork
2025-12-04 16:41 ` ✓ Xe.CI.Full: " Patchwork
2025-12-05 9:19 ` [Core-for-CI] fs: PM: Fix reverse check in filesystems_freeze_callback() Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=176485679221.56921.181548856420925458@a3b018990fe9 \
--to=patchwork@emeril.freedesktop.org \
--cc=chaitanya.kumar.borah@intel.com \
--cc=intel-xe@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox