From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CFB40D116F1 for ; Mon, 1 Dec 2025 13:38:25 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7615810E3E3; Mon, 1 Dec 2025 13:38:25 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="D1lel26s"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.9]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6111210E3DC; Mon, 1 Dec 2025 13:38:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1764596303; x=1796132303; h=from:to:subject:in-reply-to:references:date:message-id: mime-version; bh=64kVHVsDv+jxixvJ3ivZLMZoZVKV1FpAcUocX8Lz8p4=; b=D1lel26s5pUDCxLu4/1zlE2eLbVK4TQyucApdd0rQQE1zoP9a/wTp8Ja 0KXebgLsTsABW4fICLtyxrbmG6IPVhW6IxJ8UpvvIc/hebGgOGfRfqc8H EVkvLbjLW6YrBW0FL/fpVZsBCMLjyUMBm13YLA2nBEAIbS+fxeoKeJyzf wst1gQKy163GzjnDUgujB9KnK2+oesXrVUkEbxsKzJB8FwFqF15K0UFrT WjWLUH8ZOXrM8VqnjqR4wT3bHWbX+q7sVx10CniU9UWBDbCpf2r6ggTVA TQNoWQt9oBKXcYO8hfdJUQBDskO7cBuTfHc+9oUEf8gV8mUrhmZMK5JJe w==; X-CSE-ConnectionGUID: VjiI39bOTcmQ9rzHagIWCw== X-CSE-MsgGUID: xIqF5H0LRoSNUDH4eqi74g== X-IronPort-AV: E=McAfee;i="6800,10657,11629"; a="77222212" X-IronPort-AV: E=Sophos;i="6.20,240,1758610800"; d="scan'208";a="77222212" Received: from orviesa006.jf.intel.com ([10.64.159.146]) by fmvoesa103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Dec 2025 05:38:23 -0800 X-CSE-ConnectionGUID: CHLMT0PATdKVORZRhgRopw== X-CSE-MsgGUID: qsv5y9ByRtqu3F/WaRibzw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.20,240,1758610800"; d="scan'208";a="193202397" Received: from ettammin-desk.ger.corp.intel.com (HELO localhost) ([10.245.246.132]) by orviesa006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Dec 2025 05:38:21 -0800 From: Jani Nikula To: Luca Coelho , intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org Subject: Re: [PATCH v2 4/5] drm/i915/power: convert intel_wakeref_t to struct ref_tracker * In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20d6e9910f0a7faf3ed14e37db0ff0860a17e017.camel@coelho.fi> Date: Mon, 01 Dec 2025 15:38:18 +0200 Message-ID: <17a0402aa684717d643b26f006c910ba0b150c75@intel.com> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Mon, 01 Dec 2025, Luca Coelho wrote: > On Mon, 2025-12-01 at 14:25 +0200, Jani Nikula wrote: >> On Mon, 01 Dec 2025, Luca Coelho wrote: >> > On Tue, 2025-11-25 at 15:24 +0200, Jani Nikula wrote: >> > > diff --git a/drivers/gpu/drm/xe/display/xe_display_rpm.c b/drivers/gpu/drm/xe/display/xe_display_rpm.c >> > > index 340f65884812..9416ec784e39 100644 >> > > --- a/drivers/gpu/drm/xe/display/xe_display_rpm.c >> > > +++ b/drivers/gpu/drm/xe/display/xe_display_rpm.c >> > > @@ -5,6 +5,7 @@ >> > > >> > > #include "intel_display_core.h" >> > > #include "intel_display_rpm.h" >> > > +#include "intel_wakeref.h" >> > >> > Just to be sure this is not a stray change, why did you add it here? >> >> I was pretty sure it was required, maybe depending on some kconfig, >> because the include is being removed in some other places, but I can't >> reproduce the fail now. >> >> I'd say not a huge problem because it's being removed in the next patch >> no matter what. > > Makes sense. Thanks for the clarification. :) Thanks for the review, pushed the series to din. BR, Jani. -- Jani Nikula, Intel