From: Jani Nikula <jani.nikula@intel.com>
To: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Subject: Re: [PATCH 0/8] drm/{i915,xe}: refactor register helpers
Date: Wed, 04 Mar 2026 13:56:07 +0200 [thread overview]
Message-ID: <18693734614df43572488ea293c9b9b6639119d4@intel.com> (raw)
In-Reply-To: <aab6Y_u1dZjWrwWj@intel.com>
On Tue, 03 Mar 2026, Rodrigo Vivi <rodrigo.vivi@intel.com> wrote:
> On Wed, Feb 25, 2026 at 07:57:02PM +0200, Jani Nikula wrote:
>> I realized xe_reg_defs.h subtly pulls in i915_reg_defs.h from i915 via
>> the compat headers, which is ugly and wrong to say the least, and then
>> xe uses the macros all over the place.
>
> I also hadn't realized we had this mess o.O
>
>>
>> Clean this up by creating two shared headers under include/drm/intel,
>> with some related cleanups on top.
>
> Nice idea on the common header and nice clean up.
>
> Either way is good but probably drm-intel-next is easier:
>
> Acked-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Thanks, pushed the lot to drm-intel-next.
BR,
Jani.
--
Jani Nikula, Intel
prev parent reply other threads:[~2026-03-04 11:56 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-25 17:57 [PATCH 0/8] drm/{i915,xe}: refactor register helpers Jani Nikula
2026-02-25 17:57 ` [PATCH 1/8] drm/i915/reg: make masked field helpers constexpr Jani Nikula
2026-03-02 20:08 ` Michał Grzelak
2026-02-25 17:57 ` [PATCH 2/8] drm/i915/lrc: switch to _MASKED_BIT_ENABLE() and _MASKED_BIT_DISABLE() Jani Nikula
2026-03-02 20:08 ` Michał Grzelak
2026-02-25 17:57 ` [PATCH 3/8] drm/{i915, xe}/reg: rename masked field helpers REG_MASKED_FIELD*() Jani Nikula
2026-03-02 20:08 ` Michał Grzelak
2026-02-25 17:57 ` [PATCH 4/8] drm/i915/perf: prefer REG_MASKED_FIELD_ENABLE() and REG_MASKED_FIELD_DISABLE() Jani Nikula
2026-03-02 20:08 ` Michał Grzelak
2026-02-25 17:57 ` [PATCH 5/8] drm/xe/oa: " Jani Nikula
2026-03-02 20:11 ` Michał Grzelak
2026-02-25 17:57 ` [PATCH 6/8] drm/intel: add reg_bits.h for the various register content helpers Jani Nikula
2026-03-02 20:11 ` Michał Grzelak
2026-02-25 17:57 ` [PATCH 7/8] drm/intel: add pick.h for the various "picker" helpers Jani Nikula
2026-03-02 20:11 ` Michał Grzelak
2026-02-25 17:57 ` [PATCH 8/8] drm/i915/gt: prefer _PICK_EVEN() over _PICK() Jani Nikula
2026-03-02 20:12 ` Michał Grzelak
2026-02-25 19:02 ` ✗ CI.checkpatch: warning for drm/{i915,xe}: refactor register helpers Patchwork
2026-02-25 19:03 ` ✓ CI.KUnit: success " Patchwork
2026-02-25 19:39 ` ✗ Xe.CI.BAT: failure " Patchwork
2026-02-25 22:15 ` ✗ Xe.CI.FULL: " Patchwork
2026-03-03 15:12 ` [PATCH 0/8] " Rodrigo Vivi
2026-03-04 11:56 ` Jani Nikula [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18693734614df43572488ea293c9b9b6639119d4@intel.com \
--to=jani.nikula@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox