Re: [PATCH 2/2] drm/xe/bb: assert width in xe_bb_create_migration_job()

[Nirmoy Das <nirmoy.das@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 1168 bytes --]


On 3/20/2024 12:27 PM, Matthew Auld wrote:
> The q->width should always be exactly one here for migration queue/vm.
> The width will anyway be overridden later since we need to emit two
> jumps for special migration jobs. Enforce that here to ensure caller is
> not doing something strange. While here also convert to the helper to
> determine if the queue is migration based.
>
> Signed-off-by: Matthew Auld<matthew.auld@intel.com>
> Cc: Nirmoy Das<nirmoy.das@intel.com>
Reviewed-by: Nirmoy Das <nirmoy.das@intel.com>
> ---
>   drivers/gpu/drm/xe/xe_bb.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_bb.c b/drivers/gpu/drm/xe/xe_bb.c
> index a35e0781b7b9..541361caff3b 100644
> --- a/drivers/gpu/drm/xe/xe_bb.c
> +++ b/drivers/gpu/drm/xe/xe_bb.c
> @@ -86,7 +86,8 @@ struct xe_sched_job *xe_bb_create_migration_job(struct xe_exec_queue *q,
>   	};
>   
>   	xe_gt_assert(q->gt, second_idx <= bb->len);
> -	xe_gt_assert(q->gt, q->vm->flags & XE_VM_FLAG_MIGRATION);
> +	xe_gt_assert(q->gt, xe_sched_job_is_migration(q));
> +	xe_gt_assert(q->gt, q->width == 1);
>   
>   	return __xe_bb_create_job(q, bb, addr);
>   }

[-- Attachment #2: Type: text/html, Size: 1944 bytes --]