Re: [PATCH V2] drm/xe/xe2hpg: Add Wa_15016589081

["Ghimiray, Himal Prasad" <himal.prasad.ghimiray@intel.com>]

On 04-09-2024 15:43, Tejas Upadhyay wrote:
> Wa_15016589081 applies to xe2_hpg renderCS
> 
> V2(Gustavo)
>    - rename bit macro
> 
> Reviewed-by: Gustavo Sousa <gustavo.sousa@intel.com>
> Signed-off-by: Tejas Upadhyay <tejas.upadhyay@intel.com>
> ---
>   drivers/gpu/drm/xe/regs/xe_gt_regs.h | 1 +
>   drivers/gpu/drm/xe/xe_wa.c           | 4 ++++
>   2 files changed, 5 insertions(+)
> 
> diff --git a/drivers/gpu/drm/xe/regs/xe_gt_regs.h b/drivers/gpu/drm/xe/regs/xe_gt_regs.h
> index 0d1a4a9f4e11..660ff42e45a6 100644
> --- a/drivers/gpu/drm/xe/regs/xe_gt_regs.h
> +++ b/drivers/gpu/drm/xe/regs/xe_gt_regs.h
> @@ -105,6 +105,7 @@
>   
>   #define CHICKEN_RASTER_1			XE_REG_MCR(0x6204, XE_REG_OPTION_MASKED)
>   #define   DIS_SF_ROUND_NEAREST_EVEN		REG_BIT(8)
> +#define   DIS_CLIP_NEGATIVE_BOUNDING_BOX	REG_BIT(6)
>   
>   #define CHICKEN_RASTER_2			XE_REG_MCR(0x6208, XE_REG_OPTION_MASKED)
>   #define   TBIMR_FAST_CLIP			REG_BIT(5)
> diff --git a/drivers/gpu/drm/xe/xe_wa.c b/drivers/gpu/drm/xe/xe_wa.c
> index 28b7f95b6c2f..d424992514a4 100644
> --- a/drivers/gpu/drm/xe/xe_wa.c
> +++ b/drivers/gpu/drm/xe/xe_wa.c
> @@ -733,6 +733,10 @@ static const struct xe_rtp_entry_sr lrc_was[] = {
>   			     DIS_PARTIAL_AUTOSTRIP |
>   			     DIS_AUTOSTRIP))
>   	},
> +	{ XE_RTP_NAME("15016589081"),
> +	  XE_RTP_RULES(GRAPHICS_VERSION(2001), ENGINE_CLASS(RENDER)),
> +	  XE_RTP_ACTIONS(SET(CHICKEN_RASTER_1, DIS_CLIP_NEGATIVE_BOUNDING_BOX))
> +	},

LGTM.
Reviewed-by: Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com>

>   
>   	{}
>   };