Re: [PATCH 1/2] drm/xe/vf: Don't try Driver-FLR if VF

[Michal Wajdeczko <michal.wajdeczko@intel.com>]

On 11.03.2025 15:25, Ghimiray, Himal Prasad wrote:
> 
> 
> On 11-03-2025 19:27, Michal Wajdeczko wrote:
>> Driver-FLR can't be triggered from the VF driver, so treat it
>> as disabled if VF. While around, fix also the message, as it
>> shouldn't be printed just 'once' as we may have many devices.
>>
> 
> does it need fixes tag ?

it's more a gap than a bug, so not sure if Fixes: tag is needed, and
even if it does, I'm not sure which commit to blame

> 
>> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
>> ---
>>   drivers/gpu/drm/xe/xe_device.c | 14 ++++++++++----
>>   1 file changed, 10 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/xe/xe_device.c b/drivers/gpu/drm/xe/
>> xe_device.c
>> index 5d79b439dd62..a2afa8a88997 100644
>> --- a/drivers/gpu/drm/xe/xe_device.c
>> +++ b/drivers/gpu/drm/xe/xe_device.c
>> @@ -504,7 +504,15 @@ ALLOW_ERROR_INJECTION(xe_device_create, ERRNO); /
>> * See xe_pci_probe() */
>>     static bool xe_driver_flr_disabled(struct xe_device *xe)
>>   {
>> -    return xe_mmio_read32(xe_root_tile_mmio(xe), GU_CNTL_PROTECTED) &
>> DRIVERINT_FLR_DIS;
>> +    if (IS_SRIOV_VF(xe))
>> +        return true;
>> +
>> +    if (xe_mmio_read32(xe_root_tile_mmio(xe), GU_CNTL_PROTECTED) &
>> DRIVERINT_FLR_DIS) {
>> +        drm_info(&xe->drm, "Driver-FLR disabled by BIOS\n");
>> +        return true;
>> +    }
>> +
>> +    return false;
>>   }
>>     /*
>> @@ -568,10 +576,8 @@ static void __xe_driver_flr(struct xe_device *xe)
>>     static void xe_driver_flr(struct xe_device *xe)
>>   {
>> -    if (xe_driver_flr_disabled(xe)) {
>> -        drm_info_once(&xe->drm, "BIOS Disabled Driver-FLR\n");
>> +    if (xe_driver_flr_disabled(xe))
>>           return;
>> -    }
> 
> Change LGTM
> Reviewed-by: Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com>

thanks!

> 
>>         __xe_driver_flr(xe);
>>   }
>