Re: [PATCH v2 1/2] drm/xe/vf: Avoid queuing migration recovery if queued or teardown is active

[Michal Wajdeczko <michal.wajdeczko@intel.com>]

On 12/8/2025 8:27 AM, Satyanarayana K V P wrote:
> Ensure VF migration recovery work is only queued when no recovery is
> already queued and teardown is not in progress.
> 
> Fixes: b47c0c07c350 ("drm/xe/vf: Teardown VF post migration worker on driver unload")
> Signed-off-by: Satyanarayana K V P <satyanarayana.k.v.p@intel.com>
> Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
> Cc: Matthew Brost <matthew.brost@intel.com>
> Cc: Tomasz Lis <tomasz.lis@intel.com>

nit: subject is little too long, maybe just:

	drm/xe/vf: Fix queuing of recovery work

but fix is fine, so

Reviewed-by: Michal Wajdeczko <michal.wajdeczko@intel.com>

> 
> ---
> V1 -> V2:
> - New commit (Machal W & Matt B)
> ---
>  drivers/gpu/drm/xe/xe_gt_sriov_vf.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_gt_sriov_vf.c b/drivers/gpu/drm/xe/xe_gt_sriov_vf.c
> index 3c806c8e5f3e..47612e67d462 100644
> --- a/drivers/gpu/drm/xe/xe_gt_sriov_vf.c
> +++ b/drivers/gpu/drm/xe/xe_gt_sriov_vf.c
> @@ -781,7 +781,7 @@ static void vf_start_migration_recovery(struct xe_gt *gt)
>  
>  	spin_lock(&gt->sriov.vf.migration.lock);
>  
> -	if (!gt->sriov.vf.migration.recovery_queued ||
> +	if (!gt->sriov.vf.migration.recovery_queued &&
>  	    !gt->sriov.vf.migration.recovery_teardown) {
>  		gt->sriov.vf.migration.recovery_queued = true;
>  		WRITE_ONCE(gt->sriov.vf.migration.recovery_inprogress, true);