Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Thomas Hellström" <thomas.hellstrom@linux.intel.com>
To: intel-xe@lists.freedesktop.org
Subject: [Intel-xe] [PATCH 2/2] drm/xe/tests: Grab a memory access reference around the migrate sanity test
Date: Thu,  2 Mar 2023 13:42:58 +0100	[thread overview]
Message-ID: <20230302124258.91081-3-thomas.hellstrom@linux.intel.com> (raw)
In-Reply-To: <20230302124258.91081-1-thomas.hellstrom@linux.intel.com>

It appears we don't hold a memory access reference for the accesses in
this test, which may results in printed warnings and possibly the GT
not woken up for the memory accesses.

Add a memory access reference around the test.

Signed-off-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
---
 drivers/gpu/drm/xe/tests/xe_migrate.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/xe/tests/xe_migrate.c b/drivers/gpu/drm/xe/tests/xe_migrate.c
index 0de17e90aba9..b7e4a126e8b7 100644
--- a/drivers/gpu/drm/xe/tests/xe_migrate.c
+++ b/drivers/gpu/drm/xe/tests/xe_migrate.c
@@ -366,7 +366,9 @@ static int migrate_test_run_device(struct xe_device *xe)
 
 		kunit_info(test, "Testing gt id %d.\n", id);
 		xe_vm_lock(m->eng->vm, &ww, 0, true);
+		xe_device_mem_access_get(xe);
 		xe_migrate_sanity_test(m, test);
+		xe_device_mem_access_put(xe);
 		xe_vm_unlock(m->eng->vm, &ww);
 	}
 
-- 
2.39.2


  parent reply	other threads:[~2023-03-02 12:43 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-02 12:42 [Intel-xe] [PATCH 0/2] Fix kunit test building and missing memory reference Thomas Hellström
2023-03-02 12:42 ` [Intel-xe] [PATCH 1/2] drm/xe/tests: Remove CONFIG_FB dependency Thomas Hellström
2023-03-02 13:06   ` Matthew Auld
2023-03-07 13:47     ` Thomas Hellström
2023-03-02 12:42 ` Thomas Hellström [this message]
2023-03-02 13:06   ` [Intel-xe] [PATCH 2/2] drm/xe/tests: Grab a memory access reference around the migrate sanity test Matthew Auld
2023-03-03  6:20   ` Niranjana Vishwanathapura
2023-03-02 13:38 ` [Intel-xe] ✓ CI.Patch_applied: success for Fix kunit test building and missing memory reference Patchwork
2023-03-02 13:39 ` [Intel-xe] ✓ CI.KUnit: " Patchwork
2023-03-02 13:43 ` [Intel-xe] ✓ CI.Build: " Patchwork
2023-03-03 13:37 ` [Intel-xe] ✓ CI.Patch_applied: " Patchwork
2023-03-03 13:38 ` [Intel-xe] ✓ CI.KUnit: " Patchwork
2023-03-03 13:41 ` [Intel-xe] ✗ CI.Build: failure " Patchwork
2023-03-03 13:48 ` [Intel-xe] ✓ CI.Patch_applied: success " Patchwork
2023-03-03 13:49 ` [Intel-xe] ✓ CI.KUnit: " Patchwork
2023-03-03 13:53 ` [Intel-xe] ✓ CI.Build: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230302124258.91081-3-thomas.hellstrom@linux.intel.com \
    --to=thomas.hellstrom@linux.intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox