Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Thomas Hellström" <thomas.hellstrom@linux.intel.com>
To: dri-devel@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Subject: [Intel-xe] [PATCH 0/2] drm/xe: Fix unprotected rebind_list accesses
Date: Wed, 10 May 2023 16:19:30 +0200	[thread overview]
Message-ID: <20230510141932.413348-1-thomas.hellstrom@linux.intel.com> (raw)

Each VM has two rebind lists, one protected by the VM resv, the other
one protected essentially by the VM notifier.list_lock. This series
intends to fix two points of illegal access.

Patch 1 fixes an access of VM rebind_lists' link without the VM resv held.
Patch 2 fixes an issue where the VMA may not be removed from the
VM notifier.rebind_list on VMA destruction.

Thomas Hellström (2):
  drm/xe: Fix unlocked access of the vma::rebind_link
  drm/xe: Properly remove the vma from the vm::notifer::rebind_list when
    destroyed

 drivers/gpu/drm/xe/xe_vm.c | 23 ++++++++++++++++-------
 1 file changed, 16 insertions(+), 7 deletions(-)

-- 
2.39.2


             reply	other threads:[~2023-05-10 14:19 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-10 14:19 Thomas Hellström [this message]
2023-05-10 14:19 ` [Intel-xe] [PATCH 1/2] drm/xe: Fix unlocked access of the vma::rebind_link Thomas Hellström
2023-05-11 14:57   ` Matthew Brost
2023-05-10 14:19 ` [Intel-xe] [PATCH 2/2] drm/xe: Properly remove the vma from the vm::notifer::rebind_list when destroyed Thomas Hellström
2023-05-11 14:54   ` Matthew Brost
2023-05-11 15:38     ` Thomas Hellström
2023-05-12  1:31       ` Matthew Brost
2023-05-10 14:22 ` [Intel-xe] ✓ CI.Patch_applied: success for drm/xe: Fix unprotected rebind_list accesses Patchwork
2023-05-10 14:23 ` [Intel-xe] ✓ CI.KUnit: " Patchwork
2023-05-10 14:27 ` [Intel-xe] ✓ CI.Build: " Patchwork
2023-05-10 14:52 ` [Intel-xe] ○ CI.BAT: info " Patchwork
2023-05-10 20:36 ` [Intel-xe] [PATCH 0/2] " Souza, Jose

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230510141932.413348-1-thomas.hellstrom@linux.intel.com \
    --to=thomas.hellstrom@linux.intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox