Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Thomas Hellström" <thomas.hellstrom@linux.intel.com>
To: intel-xe@lists.freedesktop.org
Subject: [Intel-xe] [PATCH v3 2/2] fixup! drm/xe: Introduce a new DRM driver for Intel GPUs
Date: Tue, 16 May 2023 16:47:30 +0200	[thread overview]
Message-ID: <20230516144730.38898-3-thomas.hellstrom@linux.intel.com> (raw)
In-Reply-To: <20230516144730.38898-1-thomas.hellstrom@linux.intel.com>

drm/xe: Properly remove the vma from the vm::notifer::rebind_list when destroyed

If a vma was destroyed with the bo evicted, it might happen that we forget
to remove it from the notifer::rebind_list. Fix to make sure that really
happens.

v2:
- Remove an unnecessarily verbose comment how to avoid taking a lock.
(Matthew Brost)

Cc: Oded Gabbay <ogabbay@kernel.org>
Signed-off-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
Reviewed-by: Matthew Brost <matthew.brost@intel.com>
---
 drivers/gpu/drm/xe/xe_vm.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/gpu/drm/xe/xe_vm.c b/drivers/gpu/drm/xe/xe_vm.c
index 5f93d78c2e58..2aa5bf9cfee1 100644
--- a/drivers/gpu/drm/xe/xe_vm.c
+++ b/drivers/gpu/drm/xe/xe_vm.c
@@ -978,6 +978,9 @@ static void xe_vma_destroy(struct xe_vma *vma, struct dma_fence *fence)
 	} else {
 		xe_bo_assert_held(vma->bo);
 		list_del(&vma->bo_link);
+		spin_lock(&vm->notifier.list_lock);
+		list_del(&vma->notifier.rebind_link);
+		spin_unlock(&vm->notifier.list_lock);
 		if (!vma->bo->vm)
 			vm_remove_extobj(vma);
 	}
-- 
2.39.2


  parent reply	other threads:[~2023-05-16 14:48 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-16 14:47 [Intel-xe] [PATCH v3 0/2] drm/xe: Fix unprotected rebind_list accesses Thomas Hellström
2023-05-16 14:47 ` [Intel-xe] [PATCH v3 1/2] fixup! drm/xe: Introduce a new DRM driver for Intel GPUs Thomas Hellström
2023-05-16 14:47 ` Thomas Hellström [this message]
2023-05-16 14:50 ` [Intel-xe] ✓ CI.Patch_applied: success for drm/xe: Fix unprotected rebind_list accesses Patchwork
2023-05-16 14:51 ` [Intel-xe] ✓ CI.KUnit: " Patchwork
2023-05-16 14:55 ` [Intel-xe] ✓ CI.Build: " Patchwork
2023-05-16 15:13 ` [Intel-xe] ○ CI.BAT: info " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230516144730.38898-3-thomas.hellstrom@linux.intel.com \
    --to=thomas.hellstrom@linux.intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox