From: Matthew Brost <matthew.brost@intel.com>
To: <intel-xe@lists.freedesktop.org>
Subject: [Intel-xe] [PATCH 6/8] drm/xe: Ensure LR engines are not persistent
Date: Sun, 21 May 2023 18:50:38 -0700 [thread overview]
Message-ID: <20230522015040.3849776-7-matthew.brost@intel.com> (raw)
In-Reply-To: <20230522015040.3849776-1-matthew.brost@intel.com>
With our ref counting scheme long running (LR) engines only close
properly if not persistent, ensure that LR engines are non-persistent.
v2: spell out LR
Signed-off-by: Matthew Brost <matthew.brost@intel.com>
Reviewed-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
---
drivers/gpu/drm/xe/xe_engine.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/xe/xe_engine.c b/drivers/gpu/drm/xe/xe_engine.c
index d1e84d7adbd4..91600b1e8249 100644
--- a/drivers/gpu/drm/xe/xe_engine.c
+++ b/drivers/gpu/drm/xe/xe_engine.c
@@ -596,7 +596,9 @@ int xe_engine_create_ioctl(struct drm_device *dev, void *data,
return -ENOENT;
e = xe_engine_create(xe, vm, logical_mask,
- args->width, hwe, ENGINE_FLAG_PERSISTENT);
+ args->width, hwe,
+ xe_vm_no_dma_fences(vm) ? 0 :
+ ENGINE_FLAG_PERSISTENT);
xe_vm_put(vm);
if (IS_ERR(e))
return PTR_ERR(e);
--
2.34.1
next prev parent reply other threads:[~2023-05-22 1:50 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-22 1:50 [Intel-xe] [PATCH 0/8] Scheduler changes for upstreaming Matthew Brost
2023-05-22 1:50 ` [Intel-xe] [PATCH 1/8] fixup! drm/sched: Convert drm scheduler to use a work queue rather than kthread Matthew Brost
2023-05-22 14:44 ` Rodrigo Vivi
2023-05-22 1:50 ` [Intel-xe] [PATCH 2/8] drm/sched: Move schedule policy to scheduler Matthew Brost
2023-05-22 1:50 ` [Intel-xe] [PATCH 3/8] drm/sched: Add DRM_SCHED_POLICY_SINGLE_ENTITY scheduling policy Matthew Brost
2023-05-22 5:48 ` Christopher Snowhill
2023-05-23 5:49 ` Matthew Brost
2023-05-22 6:52 ` Christopher Snowhill
2023-05-22 7:52 ` Christopher Snowhill
2023-05-22 1:50 ` [Intel-xe] [PATCH 4/8] drm/xe: Use DRM_SCHED_POLICY_SINGLE_ENTITY mode Matthew Brost
2023-05-22 1:50 ` [Intel-xe] [PATCH 5/8] drm/xe: Long running job update Matthew Brost
2023-05-22 1:50 ` Matthew Brost [this message]
2023-05-22 1:50 ` [Intel-xe] [PATCH 7/8] drm/xe: Only try to lock external BOs in VM bind Matthew Brost
2023-05-22 1:50 ` [Intel-xe] [PATCH 8/8] drm/xe: VM LRU bulk move Matthew Brost
2023-05-22 1:52 ` [Intel-xe] ✓ CI.Patch_applied: success for Scheduler changes for upstreaming Patchwork
2023-05-22 1:54 ` [Intel-xe] ✓ CI.KUnit: " Patchwork
2023-05-22 1:58 ` [Intel-xe] ✓ CI.Build: " Patchwork
2023-05-22 4:39 ` [Intel-xe] [PATCH 0/8] " Christopher Snowhill
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230522015040.3849776-7-matthew.brost@intel.com \
--to=matthew.brost@intel.com \
--cc=intel-xe@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox