From: "Thomas Hellström" <thomas.hellstrom@linux.intel.com>
To: intel-xe@lists.freedesktop.org
Subject: [Intel-xe] [PATCH] drm/xe: Fix engine lookup refcount race
Date: Thu, 25 May 2023 10:16:15 +0200 [thread overview]
Message-ID: <20230525081615.179819-1-thomas.hellstrom@linux.intel.com> (raw)
Fix a race where the engine could disappear between lookup unlock and
xe_engine_get().
Signed-off-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
---
drivers/gpu/drm/xe/xe_engine.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/xe/xe_engine.c b/drivers/gpu/drm/xe/xe_engine.c
index 094ec17d3004..3a400a546dfe 100644
--- a/drivers/gpu/drm/xe/xe_engine.c
+++ b/drivers/gpu/drm/xe/xe_engine.c
@@ -161,10 +161,9 @@ struct xe_engine *xe_engine_lookup(struct xe_file *xef, u32 id)
mutex_lock(&xef->engine.lock);
e = xa_load(&xef->engine.xa, id);
- mutex_unlock(&xef->engine.lock);
-
if (e)
xe_engine_get(e);
+ mutex_unlock(&xef->engine.lock);
return e;
}
--
2.39.2
next reply other threads:[~2023-05-25 8:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-25 8:16 Thomas Hellström [this message]
2023-05-25 8:20 ` [Intel-xe] ✓ CI.Patch_applied: success for drm/xe: Fix engine lookup refcount race Patchwork
2023-05-25 8:22 ` [Intel-xe] ✓ CI.KUnit: " Patchwork
2023-05-25 8:25 ` [Intel-xe] ✓ CI.Build: " Patchwork
2023-05-25 8:54 ` [Intel-xe] ○ CI.BAT: info " Patchwork
2023-05-25 10:52 ` [Intel-xe] [PATCH] " Matthew Auld
2023-05-25 11:29 ` Thomas Hellström
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230525081615.179819-1-thomas.hellstrom@linux.intel.com \
--to=thomas.hellstrom@linux.intel.com \
--cc=intel-xe@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox