Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Aravind Iddamsetty <aravind.iddamsetty@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: matthew.d.roper@intel.com
Subject: [Intel-xe] [PATCH 0/1] Fix stolen memory size calculation
Date: Sat, 10 Jun 2023 00:22:48 +0530	[thread overview]
Message-ID: <20230609185249.2032370-1-aravind.iddamsetty@intel.com> (raw)

The stolen memory is not being calculated properly, DSMBASE is
considered as stolen base which is wrong. The stolen base should be
either GSMBASE or FLAT_CCS_BASE_ADDR when flat ccs is enabled.

debugfs output showing wrong stolen size as 8MiB while it should be 16MiB:
# cat /sys/kernel/debug/dri/1/stolen_mm
  use_type: 1
  use_tt: 0
  size: 8388608
  usage: 0
default_page_size: 64KiB
visible_avail: 8MiB
visible_size: 8MiB
chunk_size: 64KiB, total: 8MiB, free: 8MiB
order-7 free: 8MiB, pages: 1
order-6 free: 0KiB, pages: 0
order-5 free: 0KiB, pages: 0
order-4 free: 0KiB, pages: 0
order-3 free: 0KiB, pages: 0
order-2 free: 0KiB, pages: 0
order-1 free: 0KiB, pages: 0
order-0 free: 0KiB, pages: 0
man size:8388608

output with this patch:
# cat /sys/kernel/debug/dri/1/stolen_mm
  use_type: 1
  use_tt: 0
  size: 16777216
  usage: 0
default_page_size: 64KiB
visible_avail: 16MiB
visible_size: 16MiB
chunk_size: 64KiB, total: 16MiB, free: 16MiB
order-8 free: 16MiB, pages: 1
order-7 free: 0KiB, pages: 0
order-6 free: 0KiB, pages: 0
order-5 free: 0KiB, pages: 0
order-4 free: 0KiB, pages: 0
order-3 free: 0KiB, pages: 0
order-2 free: 0KiB, pages: 0
order-1 free: 0KiB, pages: 0
order-0 free: 0KiB, pages: 0
man size:16777216

Cc: Matt Roper <matthew.d.roper@intel.com>

Aravind Iddamsetty (1):
  drm/xe: Fix stolen memory size calculation

 drivers/gpu/drm/xe/xe_ttm_stolen_mgr.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

-- 
2.25.1


             reply	other threads:[~2023-06-09 18:49 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-09 18:52 Aravind Iddamsetty [this message]
2023-06-09 18:52 ` [Intel-xe] [PATCH 1/1] drm/xe: Fix stolen memory size calculation Aravind Iddamsetty
2023-06-12 14:29   ` Ruhl, Michael J
2023-06-12 15:04     ` Iddamsetty, Aravind
2023-06-12 15:55       ` Matthew Auld
2023-06-12 16:57         ` Ruhl, Michael J
2023-06-09 19:12 ` [Intel-xe] ✓ CI.Patch_applied: success for " Patchwork
2023-06-09 19:12 ` [Intel-xe] ✗ CI.checkpatch: warning " Patchwork
2023-06-09 19:13 ` [Intel-xe] ✓ CI.KUnit: success " Patchwork
2023-06-09 19:17 ` [Intel-xe] ✓ CI.Build: " Patchwork
2023-06-09 19:17 ` [Intel-xe] ✓ CI.Hooks: " Patchwork
2023-06-09 19:19 ` [Intel-xe] ✓ CI.checksparse: " Patchwork
2023-06-09 19:53 ` [Intel-xe] ○ CI.BAT: info " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230609185249.2032370-1-aravind.iddamsetty@intel.com \
    --to=aravind.iddamsetty@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=matthew.d.roper@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox