Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Thomas Hellström" <thomas.hellstrom@linux.intel.com>
To: intel-xe@lists.freedesktop.org
Cc: intel-gfx@lists.freedesktop.org,
	"Christian König" <christian.koenig@amd.com>,
	dri-devel@lists.freedesktop.org
Subject: [Intel-xe] [PATCH v2 6/6] drm/ttm: Don't shadow the operation context
Date: Mon, 19 Jun 2023 17:22:22 +0200	[thread overview]
Message-ID: <20230619152222.11733-7-thomas.hellstrom@linux.intel.com> (raw)
In-Reply-To: <20230619152222.11733-1-thomas.hellstrom@linux.intel.com>

ttm_bo_swapout() shadows the ttm operation context which may cause
major confusion in driver callbacks when swapping out !TTM_PL_SYSTEM
memory. Fix this by reusing the operation context argument to
ttm_bo_swapout().

Cc: "Christian König" <christian.koenig@amd.com>
Cc: <dri-devel@lists.freedesktop.org>
Cc: <intel-gfx@lists.freedesktop.org>
Signed-off-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
Acked-by: Matthew Brost <matthew.brost@intel.com>
---
 drivers/gpu/drm/ttm/ttm_bo.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c
index bd5dae4d1624..615d30c4262d 100644
--- a/drivers/gpu/drm/ttm/ttm_bo.c
+++ b/drivers/gpu/drm/ttm/ttm_bo.c
@@ -1154,7 +1154,6 @@ int ttm_bo_swapout(struct ttm_buffer_object *bo, struct ttm_operation_ctx *ctx,
 	 * Move to system cached
 	 */
 	if (bo->resource->mem_type != TTM_PL_SYSTEM) {
-		struct ttm_operation_ctx ctx = { false, false };
 		struct ttm_resource *evict_mem;
 		struct ttm_place hop;
 
@@ -1164,7 +1163,7 @@ int ttm_bo_swapout(struct ttm_buffer_object *bo, struct ttm_operation_ctx *ctx,
 		if (unlikely(ret))
 			goto out;
 
-		ret = ttm_bo_handle_move_mem(bo, evict_mem, true, &ctx, &hop);
+		ret = ttm_bo_handle_move_mem(bo, evict_mem, true, ctx, &hop);
 		if (unlikely(ret != 0)) {
 			WARN(ret == -EMULTIHOP, "Unexpected multihop in swaput - likely driver bug.\n");
 			goto out;
-- 
2.40.1


  parent reply	other threads:[~2023-06-19 15:22 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-19 15:22 [Intel-xe] [PATCH v2 0/6] drm/xe: Eviction fixes and optimizations Thomas Hellström
2023-06-19 15:22 ` [Intel-xe] [PATCH v2 1/6] drm/xe/bo: Don't limit the TT manager to half of system memory Thomas Hellström
2023-06-19 16:46   ` Matthew Auld
2023-06-19 17:14     ` Thomas Hellström
2023-06-19 15:22 ` [Intel-xe] [PATCH v2 2/6] drm/xe/bo: Fix swapin when moving to VRAM Thomas Hellström
2023-06-19 15:22 ` [Intel-xe] [PATCH v2 3/6] drm/xe/bo: Avoid creating a system resource when allocating a fresh VRAM bo Thomas Hellström
2023-06-21 22:16   ` Matthew Brost
2023-06-19 15:22 ` [Intel-xe] [PATCH v2 4/6] drm/xe/bo: Gracefully handle errors from ttm_bo_move_accel_cleanup() Thomas Hellström
2023-06-21 22:22   ` Matthew Brost
2023-06-19 15:22 ` [Intel-xe] [PATCH v2 5/6] drm/xe/bo: Evict VRAM to TT rather than to system Thomas Hellström
2023-06-19 15:22 ` Thomas Hellström [this message]
2023-06-19 15:24 ` [Intel-xe] ✓ CI.Patch_applied: success for drm/xe: Eviction fixes and optimizations (rev2) Patchwork
2023-06-19 15:24 ` [Intel-xe] ✓ CI.checkpatch: " Patchwork
2023-06-19 15:26 ` [Intel-xe] ✓ CI.KUnit: " Patchwork
2023-06-19 15:29 ` [Intel-xe] ✓ CI.Build: " Patchwork
2023-06-19 15:30 ` [Intel-xe] ✓ CI.Hooks: " Patchwork
2023-06-19 15:31 ` [Intel-xe] ✗ CI.checksparse: warning " Patchwork
2023-06-19 16:11 ` [Intel-xe] ○ CI.BAT: info " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230619152222.11733-7-thomas.hellstrom@linux.intel.com \
    --to=thomas.hellstrom@linux.intel.com \
    --cc=christian.koenig@amd.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox