From: "Thomas Hellström" <thomas.hellstrom@linux.intel.com>
To: intel-xe@lists.freedesktop.org
Subject: [Intel-xe] [CI 1/4] drm/xe/bo: Fix swapin when moving to VRAM
Date: Mon, 26 Jun 2023 15:58:21 +0200 [thread overview]
Message-ID: <20230626135824.21984-1-thomas.hellstrom@linux.intel.com> (raw)
When a source system resource had been swapped out, we incorrectly
assumed that we were lacking source data for a move and therefore
cleared the destination instead of swapping in and copying the
swapped-out data. Fix this.
Signed-off-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
Reviewed-by: Matthew Brost <matthew.brost@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20230619152222.11733-3-thomas.hellstrom@linux.intel.com
---
drivers/gpu/drm/xe/xe_bo.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/xe/xe_bo.c b/drivers/gpu/drm/xe/xe_bo.c
index 71a14e1f25be..d2f4575d8548 100644
--- a/drivers/gpu/drm/xe/xe_bo.c
+++ b/drivers/gpu/drm/xe/xe_bo.c
@@ -568,6 +568,7 @@ static int xe_bo_move(struct ttm_buffer_object *ttm_bo, bool evict,
struct xe_tile *tile = NULL;
struct dma_fence *fence;
bool move_lacks_source;
+ bool tt_has_data;
bool needs_clear;
int ret = 0;
@@ -590,8 +591,10 @@ static int xe_bo_move(struct ttm_buffer_object *ttm_bo, bool evict,
goto out;
}
- move_lacks_source = !resource_is_vram(old_mem) &&
- (!ttm || !ttm_tt_is_populated(ttm));
+ tt_has_data = ttm && (ttm_tt_is_populated(ttm) ||
+ (ttm->page_flags & TTM_TT_FLAG_SWAPPED));
+
+ move_lacks_source = !resource_is_vram(old_mem) && !tt_has_data;
needs_clear = (ttm && ttm->page_flags & TTM_TT_FLAG_ZERO_ALLOC) ||
(!ttm && ttm_bo->type == ttm_bo_type_device);
--
2.40.1
next reply other threads:[~2023-06-26 13:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-26 13:58 Thomas Hellström [this message]
2023-06-26 13:58 ` [Intel-xe] [CI 2/4] drm/xe/bo: Avoid creating a system resource when allocating a fresh VRAM bo Thomas Hellström
2023-06-26 13:58 ` [Intel-xe] [CI 3/4] drm/xe/bo: Gracefully handle errors from ttm_bo_move_accel_cleanup() Thomas Hellström
2023-06-26 13:58 ` [Intel-xe] [CI 4/4] drm/xe/bo: Evict VRAM to TT rather than to system Thomas Hellström
2023-06-26 14:00 ` [Intel-xe] ✓ CI.Patch_applied: success for series starting with [CI,1/4] drm/xe/bo: Fix swapin when moving to VRAM Patchwork
2023-06-26 14:00 ` [Intel-xe] ✓ CI.checkpatch: " Patchwork
2023-06-26 14:02 ` [Intel-xe] ✓ CI.KUnit: " Patchwork
2023-06-26 14:05 ` [Intel-xe] ✓ CI.Build: " Patchwork
2023-06-26 14:06 ` [Intel-xe] ✓ CI.Hooks: " Patchwork
2023-06-26 14:07 ` [Intel-xe] ✓ CI.checksparse: " Patchwork
2023-06-26 14:47 ` [Intel-xe] ○ CI.BAT: info " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230626135824.21984-1-thomas.hellstrom@linux.intel.com \
--to=thomas.hellstrom@linux.intel.com \
--cc=intel-xe@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox