Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Thomas Hellström" <thomas.hellstrom@linux.intel.com>
To: intel-xe@lists.freedesktop.org
Subject: [Intel-xe] [PATCH v3 3/4] drm/xe/bo: Gracefully handle errors from ttm_bo_move_accel_cleanup().
Date: Mon, 26 Jun 2023 20:17:40 +0200	[thread overview]
Message-ID: <20230626181741.32820-4-thomas.hellstrom@linux.intel.com> (raw)
In-Reply-To: <20230626181741.32820-1-thomas.hellstrom@linux.intel.com>

The function ttm_bo_move_accel_cleanup() attempts to help pipeline a
move, and in doing so, needs memory allocations which may fail.

Rather than failing in a state where the new resource may freed while
accessed by the copy engine, sync uninterruptible and do a failsafe
cleanup.

v2:
- Don't try to attach the signaled fence on ttm_bo_move_accel_cleanup()
  error.

Signed-off-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
---
 drivers/gpu/drm/xe/xe_bo.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/gpu/drm/xe/xe_bo.c b/drivers/gpu/drm/xe/xe_bo.c
index 73e06597c84d..03b83150e8cd 100644
--- a/drivers/gpu/drm/xe/xe_bo.c
+++ b/drivers/gpu/drm/xe/xe_bo.c
@@ -700,6 +700,11 @@ static int xe_bo_move(struct ttm_buffer_object *ttm_bo, bool evict,
 		if (!move_lacks_source) {
 			ret = ttm_bo_move_accel_cleanup(ttm_bo, fence, evict,
 							true, new_mem);
+			if (ret) {
+				dma_fence_wait(fence, false);
+				ttm_bo_move_null(ttm_bo, new_mem);
+				ret = 0;
+			}
 		} else {
 			/*
 			 * ttm_bo_move_accel_cleanup() may blow up if
-- 
2.40.1


  parent reply	other threads:[~2023-06-26 18:18 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-26 18:17 [Intel-xe] [PATCH v3 0/4] drm/xe: Eviction fixes and optimizations Thomas Hellström
2023-06-26 18:17 ` [Intel-xe] [PATCH v3 1/4] drm/xe/bo: Fix swapin when moving to VRAM Thomas Hellström
2023-06-26 18:17 ` [Intel-xe] [PATCH v3 2/4] drm/xe/bo: Avoid creating a system resource when allocating a fresh VRAM bo Thomas Hellström
2023-06-27  8:54   ` Matthew Auld
2023-06-26 18:17 ` Thomas Hellström [this message]
2023-06-27  8:55   ` [Intel-xe] [PATCH v3 3/4] drm/xe/bo: Gracefully handle errors from ttm_bo_move_accel_cleanup() Matthew Auld
2023-06-26 18:17 ` [Intel-xe] [PATCH v3 4/4] drm/xe/bo: Evict VRAM to TT rather than to system Thomas Hellström
2023-06-26 18:20 ` [Intel-xe] ✓ CI.Patch_applied: success for drm/xe: Eviction fixes and optimizations (rev3) Patchwork
2023-06-26 18:20 ` [Intel-xe] ✓ CI.checkpatch: " Patchwork
2023-06-26 18:22 ` [Intel-xe] ✓ CI.KUnit: " Patchwork
2023-06-26 18:25 ` [Intel-xe] ✓ CI.Build: " Patchwork
2023-06-26 18:26 ` [Intel-xe] ✓ CI.Hooks: " Patchwork
2023-06-26 18:27 ` [Intel-xe] ✓ CI.checksparse: " Patchwork
2023-06-26 19:11 ` [Intel-xe] ○ CI.BAT: info " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230626181741.32820-4-thomas.hellstrom@linux.intel.com \
    --to=thomas.hellstrom@linux.intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox