From: Brian Welty <brian.welty@intel.com>
To: intel-xe@lists.freedesktop.org
Subject: [Intel-xe] [PATCH] drm/xe: Fix BUG_ON during bind with prefetch
Date: Wed, 12 Jul 2023 19:01:44 -0700 [thread overview]
Message-ID: <20230713020144.21594-1-brian.welty@intel.com> (raw)
It was missed that print_ops needs to include DRM_GPUVA_OP_PREFETCH.
Else we hit the impossible BUG_ON:
[ 886.371040] ------------[ cut here ]------------
[ 886.371047] kernel BUG at drivers/gpu/drm/xe/xe_vm.c:2234!
[ 886.371216] invalid opcode: 0000 [#1] PREEMPT SMP NOPTI
[ 886.371229] CPU: 1 PID: 3132 Comm: xe_exec_fault_m Tainted: G W 6.4.0-xe+ #16
[ 886.371257] RIP: 0010:vm_bind_ioctl_ops_create+0x45f/0x470 [xe]
...
[ 886.371517] Call Trace:
[ 886.371525] <TASK>
[ 886.371531] ? __die_body+0x1a/0x60
[ 886.371546] ? die+0x38/0x60
[ 886.371557] ? do_trap+0x10a/0x120
[ 886.371568] ? vm_bind_ioctl_ops_create+0x45f/0x470 [xe]
Fixes: d39e49e2ad38 ("drm/xe: Port Xe to GPUVA")
Signed-off-by: Brian Welty <brian.welty@intel.com>
---
drivers/gpu/drm/xe/xe_vm.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/xe/xe_vm.c b/drivers/gpu/drm/xe/xe_vm.c
index 6c216350084b..f96690e868aa 100644
--- a/drivers/gpu/drm/xe/xe_vm.c
+++ b/drivers/gpu/drm/xe/xe_vm.c
@@ -2230,6 +2230,8 @@ static void print_op(struct xe_device *xe, struct drm_gpuva_op *op)
(ULL)xe_vma_start(vma), (ULL)xe_vma_size(vma),
op->unmap.keep ? 1 : 0);
break;
+ case DRM_GPUVA_OP_PREFETCH:
+ break;
default:
XE_BUG_ON("NOT POSSIBLE");
}
--
2.38.0
next reply other threads:[~2023-07-13 2:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-13 2:01 Brian Welty [this message]
2023-07-13 2:56 ` [Intel-xe] ✓ CI.Patch_applied: success for drm/xe: Fix BUG_ON during bind with prefetch Patchwork
2023-07-13 2:56 ` [Intel-xe] ✓ CI.checkpatch: " Patchwork
2023-07-13 2:58 ` [Intel-xe] ✓ CI.KUnit: " Patchwork
2023-07-13 3:01 ` [Intel-xe] ✓ CI.Build: " Patchwork
2023-07-13 3:02 ` [Intel-xe] ✓ CI.Hooks: " Patchwork
2023-07-13 3:03 ` [Intel-xe] ✓ CI.checksparse: " Patchwork
2023-07-13 3:45 ` [Intel-xe] ○ CI.BAT: info " Patchwork
2023-07-13 5:08 ` [Intel-xe] [PATCH] " Matthew Brost
2023-07-13 19:15 ` Welty, Brian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230713020144.21594-1-brian.welty@intel.com \
--to=brian.welty@intel.com \
--cc=intel-xe@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox