From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D7032C001E0 for ; Thu, 13 Jul 2023 13:23:18 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B45FC10E6D9; Thu, 13 Jul 2023 13:23:18 +0000 (UTC) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by gabe.freedesktop.org (Postfix) with ESMTPS id DF29C10E6D9 for ; Thu, 13 Jul 2023 13:23:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1689254597; x=1720790597; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=upWfE/TUfy3vsgbc0NMXqTOnZ5NjAzB+LRWzf7Xuud0=; b=kTM3eddPrpA3BDK/j/A1AZciLCCbXI67FR2ulWHXWtqOniOBBdkYyXH0 V8fyrPPwODwZ7Js0f4psmzbzidYx0srV1x5FkWrH1/+MZlVLccJW661Kw 80tuVK2e2gi21aTFNjiNY+/kksOPM5sEHLJvsZCs1mvVn27wBRVz+4Ch3 sOEGlt7xSaNSEQAKh31Q/8ZOEPT7ryYlLMxKFFz93gAWKdkG/nDHLZW0P re9ndLjWBsOOe/ZYph0NDC2yeP1KaEf3fE5L0Q7Fs4pSMYh9EogVUgYFf GdPo9jlkAwEOQQFiRbjc7MFWPwULkZVfoPN9+xgC3dYK6ue3r3m+RyiQ8 Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10770"; a="345497942" X-IronPort-AV: E=Sophos;i="6.01,202,1684825200"; d="scan'208";a="345497942" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jul 2023 06:23:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10770"; a="787455317" X-IronPort-AV: E=Sophos;i="6.01,202,1684825200"; d="scan'208";a="787455317" Received: from rossdevx-mobl.ger.corp.intel.com (HELO mwauld-desk1.intel.com) ([10.252.28.133]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jul 2023 06:23:16 -0700 From: Matthew Auld To: intel-xe@lists.freedesktop.org Date: Thu, 13 Jul 2023 14:22:50 +0100 Message-ID: <20230713132244.459605-17-matthew.auld@intel.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230713132244.459605-12-matthew.auld@intel.com> References: <20230713132244.459605-12-matthew.auld@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [Intel-xe] [PATCH v13 05/10] drm/xe/mmio: grab mem_access in xe_mmio_ioctl X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rodrigo Vivi Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" Any kind of device memory access should first ensure the device is not suspended, mmio included. Signed-off-by: Matthew Auld Cc: Rodrigo Vivi Reviewed-by: Matthew Brost --- drivers/gpu/drm/xe/xe_mmio.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/xe/xe_mmio.c b/drivers/gpu/drm/xe/xe_mmio.c index 5effb21db9d4..434f7c2cb3c9 100644 --- a/drivers/gpu/drm/xe/xe_mmio.c +++ b/drivers/gpu/drm/xe/xe_mmio.c @@ -477,6 +477,7 @@ int xe_mmio_ioctl(struct drm_device *dev, void *data, */ reg = XE_REG(args->addr); + xe_device_mem_access_get(xe); xe_force_wake_get(gt_to_fw(gt), XE_FORCEWAKE_ALL); if (args->flags & DRM_XE_MMIO_WRITE) { @@ -520,6 +521,7 @@ int xe_mmio_ioctl(struct drm_device *dev, void *data, exit: xe_force_wake_put(gt_to_fw(gt), XE_FORCEWAKE_ALL); + xe_device_mem_access_put(xe); return ret; } -- 2.41.0