From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 22FCBEB64DC for ; Mon, 17 Jul 2023 11:25:47 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id F360110E236; Mon, 17 Jul 2023 11:25:46 +0000 (UTC) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id 349D610E235 for ; Mon, 17 Jul 2023 11:25:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1689593145; x=1721129145; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=cR5o3UwzYUMBLriMtCg6wAQ2yzy1drHHiNWsmCW4PjA=; b=NGNohjDp+2xYb3kF5ztacslm0UjOdLfLZ3fcNGOnqQfZBTe/VPfjZLSY +XyUqj1Fg0hKhkL4eDHbKUqn+n7JiscCSyYvRjkKA3VZvvoERaZFia+Zr 9CdBmDRKkJBChy2PVxZ8NDP2lmEyP5PDb1g04ETidZ4URhBfAD3M/DMDO dcZqiEcJfNPMNz3dJCIxpJ9LNCD1oud7LSVTfHMxbiCxCM6T+MIwFUTvM PVFsLBsidgyLiCQ2X99shsiRxN+Jm7Td/jPkshUK+RopdHHPlJuIaWpgs Psq8WmJ6Kq537/Ywlv+gl/NOGjqMNjG0+TGkqRIlzlVLobQ+TZiq8grod A==; X-IronPort-AV: E=McAfee;i="6600,9927,10773"; a="365948475" X-IronPort-AV: E=Sophos;i="6.01,211,1684825200"; d="scan'208";a="365948475" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Jul 2023 04:25:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10773"; a="897174852" X-IronPort-AV: E=Sophos;i="6.01,211,1684825200"; d="scan'208";a="897174852" Received: from kprutko-mobl3.ger.corp.intel.com (HELO mwauld-desk1.intel.com) ([10.252.13.224]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Jul 2023 04:25:43 -0700 From: Matthew Auld To: intel-xe@lists.freedesktop.org Date: Mon, 17 Jul 2023 12:25:07 +0100 Message-ID: <20230717112502.32379-16-matthew.auld@intel.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230717112502.32379-12-matthew.auld@intel.com> References: <20230717112502.32379-12-matthew.auld@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [Intel-xe] [PATCH v14 04/10] drm/xe/guc_pc: add missing mem_access for freq_rpe_show X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rodrigo Vivi Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" The mem_access is meant to cover any kind of device level memory access, mmio included. Signed-off-by: Matthew Auld Cc: Matthew Brost Cc: Rodrigo Vivi Cc: Anshuman Gupta Reviewed-by: Anshuman Gupta --- drivers/gpu/drm/xe/xe_guc_pc.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/xe/xe_guc_pc.c b/drivers/gpu/drm/xe/xe_guc_pc.c index 3093cfeff0c2..a5aae624d11e 100644 --- a/drivers/gpu/drm/xe/xe_guc_pc.c +++ b/drivers/gpu/drm/xe/xe_guc_pc.c @@ -422,8 +422,12 @@ static ssize_t freq_rpe_show(struct device *dev, struct device_attribute *attr, char *buf) { struct xe_guc_pc *pc = dev_to_pc(dev); + struct xe_gt *gt = pc_to_gt(pc); + struct xe_device *xe = gt_to_xe(gt); + xe_device_mem_access_get(xe); pc_update_rp_values(pc); + xe_device_mem_access_put(xe); return sysfs_emit(buf, "%d\n", pc->rpe_freq); } static DEVICE_ATTR_RO(freq_rpe); -- 2.41.0