From: Jani Nikula <jani.nikula@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: Jani Nikula <jani.nikula@intel.com>, rodrigo.vivi@intel.com
Subject: [Intel-xe] [PATCH 1/9] drm/i915/irq: add dedicated intel_display_irq_init()
Date: Fri, 11 Aug 2023 12:35:51 +0300 [thread overview]
Message-ID: <20230811093559.2304457-2-jani.nikula@intel.com> (raw)
In-Reply-To: <20230811093559.2304457-1-jani.nikula@intel.com>
Continue splitting display from the rest.
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/45c247c9f5104f3e25bd8913644402a11ec3afaf.1691509966.git.jani.nikula@intel.com
(cherry picked from commit 1486d040df4df9c4bca99e74c09165aa92179dcf)
---
.../gpu/drm/i915/display/intel_display_driver.c | 2 ++
.../gpu/drm/i915/display/intel_display_irq.c | 17 +++++++++++++++++
.../gpu/drm/i915/display/intel_display_irq.h | 2 ++
drivers/gpu/drm/i915/i915_irq.c | 17 -----------------
4 files changed, 21 insertions(+), 17 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_display_driver.c b/drivers/gpu/drm/i915/display/intel_display_driver.c
index b909814ae02b..8f144d4d3c39 100644
--- a/drivers/gpu/drm/i915/display/intel_display_driver.c
+++ b/drivers/gpu/drm/i915/display/intel_display_driver.c
@@ -28,6 +28,7 @@
#include "intel_crtc.h"
#include "intel_display_debugfs.h"
#include "intel_display_driver.h"
+#include "intel_display_irq.h"
#include "intel_display_power.h"
#include "intel_display_types.h"
#include "intel_dkl_phy.h"
@@ -177,6 +178,7 @@ void intel_display_driver_early_probe(struct drm_i915_private *i915)
if (!HAS_DISPLAY(i915))
return;
+ intel_display_irq_init(i915);
intel_dkl_phy_init(i915);
intel_color_init_hooks(i915);
intel_init_cdclk_hooks(i915);
diff --git a/drivers/gpu/drm/i915/display/intel_display_irq.c b/drivers/gpu/drm/i915/display/intel_display_irq.c
index e6f172cc665a..168f6d4ce208 100644
--- a/drivers/gpu/drm/i915/display/intel_display_irq.c
+++ b/drivers/gpu/drm/i915/display/intel_display_irq.c
@@ -1699,3 +1699,20 @@ void gen11_de_irq_postinstall(struct drm_i915_private *dev_priv)
GEN11_DISPLAY_IRQ_ENABLE);
}
+void intel_display_irq_init(struct drm_i915_private *i915)
+{
+ i915->drm.vblank_disable_immediate = true;
+
+ /*
+ * Most platforms treat the display irq block as an always-on power
+ * domain. vlv/chv can disable it at runtime and need special care to
+ * avoid writing any of the display block registers outside of the power
+ * domain. We defer setting up the display irqs in this case to the
+ * runtime pm.
+ */
+ i915->display_irqs_enabled = true;
+ if (IS_VALLEYVIEW(i915) || IS_CHERRYVIEW(i915))
+ i915->display_irqs_enabled = false;
+
+ intel_hotplug_irq_init(i915);
+}
diff --git a/drivers/gpu/drm/i915/display/intel_display_irq.h b/drivers/gpu/drm/i915/display/intel_display_irq.h
index 874893f4f16d..8a2d069d3aac 100644
--- a/drivers/gpu/drm/i915/display/intel_display_irq.h
+++ b/drivers/gpu/drm/i915/display/intel_display_irq.h
@@ -78,4 +78,6 @@ void i965_pipestat_irq_handler(struct drm_i915_private *i915, u32 iir, u32 pipe_
void valleyview_pipestat_irq_handler(struct drm_i915_private *i915, u32 pipe_stats[I915_MAX_PIPES]);
void i8xx_pipestat_irq_handler(struct drm_i915_private *i915, u16 iir, u32 pipe_stats[I915_MAX_PIPES]);
+void intel_display_irq_init(struct drm_i915_private *i915);
+
#endif /* __INTEL_DISPLAY_IRQ_H__ */
diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
index 512fc0ef94a4..1723c215dcf6 100644
--- a/drivers/gpu/drm/i915/i915_irq.c
+++ b/drivers/gpu/drm/i915/i915_irq.c
@@ -1343,23 +1343,6 @@ void intel_irq_init(struct drm_i915_private *dev_priv)
/* pre-gen11 the guc irqs bits are in the upper 16 bits of the pm reg */
if (HAS_GT_UC(dev_priv) && GRAPHICS_VER(dev_priv) < 11)
to_gt(dev_priv)->pm_guc_events = GUC_INTR_GUC2HOST << 16;
-
- if (!HAS_DISPLAY(dev_priv))
- return;
-
- dev_priv->drm.vblank_disable_immediate = true;
-
- /* Most platforms treat the display irq block as an always-on
- * power domain. vlv/chv can disable it at runtime and need
- * special care to avoid writing any of the display block registers
- * outside of the power domain. We defer setting up the display irqs
- * in this case to the runtime pm.
- */
- dev_priv->display_irqs_enabled = true;
- if (IS_VALLEYVIEW(dev_priv) || IS_CHERRYVIEW(dev_priv))
- dev_priv->display_irqs_enabled = false;
-
- intel_hotplug_irq_init(dev_priv);
}
/**
--
2.39.2
next prev parent reply other threads:[~2023-08-11 9:36 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-11 9:35 [Intel-xe] [PATCH 0/9] drm/xe: i915 irq backports + display cleanups Jani Nikula
2023-08-11 9:35 ` Jani Nikula [this message]
2023-08-11 9:35 ` [Intel-xe] [PATCH 2/9] drm/i915/irq: add dg1_de_irq_postinstall() Jani Nikula
2023-08-11 9:35 ` [Intel-xe] [PATCH 3/9] drm/i915/irq: add ilk_de_irq_postinstall() Jani Nikula
2023-08-11 9:35 ` [Intel-xe] [PATCH 4/9] drm/i915/irq: move all PCH irq postinstall calls to display code Jani Nikula
2023-08-11 9:35 ` [Intel-xe] [PATCH 5/9] fixup! drm/xe/display: Implement display support Jani Nikula
2023-08-11 9:35 ` [Intel-xe] [PATCH 6/9] " Jani Nikula
2023-08-11 9:35 ` [Intel-xe] [PATCH 7/9] " Jani Nikula
2023-08-11 12:10 ` [Intel-xe] [PATCH v2] " Jani Nikula
2023-08-11 9:35 ` [Intel-xe] [PATCH 8/9] " Jani Nikula
2023-08-11 9:35 ` [Intel-xe] [PATCH 9/9] " Jani Nikula
2023-08-11 9:40 ` [Intel-xe] ✓ CI.Patch_applied: success for drm/xe: i915 irq backports + display cleanups Patchwork
2023-08-11 9:40 ` [Intel-xe] ✗ CI.checkpatch: warning " Patchwork
2023-08-11 9:41 ` [Intel-xe] ✓ CI.KUnit: success " Patchwork
2023-08-11 9:44 ` [Intel-xe] ✗ CI.Build: failure " Patchwork
2023-08-11 12:58 ` [Intel-xe] ✓ CI.Patch_applied: success for drm/xe: i915 irq backports + display cleanups (rev2) Patchwork
2023-08-11 12:58 ` [Intel-xe] ✗ CI.checkpatch: warning " Patchwork
2023-08-11 12:59 ` [Intel-xe] ✓ CI.KUnit: success " Patchwork
2023-08-11 13:03 ` [Intel-xe] ✓ CI.Build: " Patchwork
2023-08-11 13:03 ` [Intel-xe] ✓ CI.Hooks: " Patchwork
2023-08-11 13:04 ` [Intel-xe] ✗ CI.checksparse: warning " Patchwork
2023-08-17 5:33 ` [Intel-xe] [PATCH 0/9] drm/xe: i915 irq backports + display cleanups Hogander, Jouni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230811093559.2304457-2-jani.nikula@intel.com \
--to=jani.nikula@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox