Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: Lionel G Landwerlin <lionel.g.landwerlin@linux.intel.com>
Subject: [Intel-xe] [PATCH v2 1/4] fixup! drm/xe: Introduce a new DRM driver for Intel GPUs
Date: Mon, 14 Aug 2023 15:37:31 -0700	[thread overview]
Message-ID: <20230814223734.375449-2-umesh.nerlige.ramappa@intel.com> (raw)
In-Reply-To: <20230814223734.375449-1-umesh.nerlige.ramappa@intel.com>

Queries are 0-indexed, so a query with value N is invalid if the
ARRAY_SIZE is N. Modify the check to account for that.

Signed-off-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
Reviewed-by: Niranjana Vishwanathapura <niranjana.vishwanathapura@intel.com>
---
 drivers/gpu/drm/xe/xe_query.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/xe/xe_query.c b/drivers/gpu/drm/xe/xe_query.c
index 7ea235c71385..297e93a0eb8c 100644
--- a/drivers/gpu/drm/xe/xe_query.c
+++ b/drivers/gpu/drm/xe/xe_query.c
@@ -385,7 +385,7 @@ int xe_query_ioctl(struct drm_device *dev, void *data, struct drm_file *file)
 	    XE_IOCTL_DBG(xe, query->reserved[0] || query->reserved[1]))
 		return -EINVAL;
 
-	if (XE_IOCTL_DBG(xe, query->query > ARRAY_SIZE(xe_query_funcs)))
+	if (XE_IOCTL_DBG(xe, query->query >= ARRAY_SIZE(xe_query_funcs)))
 		return -EINVAL;
 
 	idx = array_index_nospec(query->query, ARRAY_SIZE(xe_query_funcs));
-- 
2.38.1


  reply	other threads:[~2023-08-14 22:37 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-14 22:37 [Intel-xe] [PATCH v2 0/4] Port CPU-GPU timestamp correlation to XE KMD Umesh Nerlige Ramappa
2023-08-14 22:37 ` Umesh Nerlige Ramappa [this message]
2023-08-14 22:37 ` [Intel-xe] [PATCH v2 2/4] fixup! drm/xe: Introduce a new DRM driver for Intel GPUs Umesh Nerlige Ramappa
2023-08-14 22:37 ` [Intel-xe] [PATCH v2 3/4] " Umesh Nerlige Ramappa
2023-08-14 22:51   ` Umesh Nerlige Ramappa
2023-08-15 14:03   ` Souza, Jose
2023-08-15 16:42     ` Niranjana Vishwanathapura
2023-08-15 18:40     ` Umesh Nerlige Ramappa
2023-08-16 22:16       ` Vivi, Rodrigo
2023-09-14 19:32       ` Rodrigo Vivi
2023-08-14 22:37 ` [Intel-xe] [PATCH v2 4/4] drm/xe: Correlate engine and cpu timestamps with better accuracy Umesh Nerlige Ramappa
2023-08-15 14:07   ` Souza, Jose
2023-08-15 16:41   ` Niranjana Vishwanathapura
2023-08-15 16:43     ` Souza, Jose
2023-08-15 18:32     ` Umesh Nerlige Ramappa
2023-09-01 17:58   ` Souza, Jose
2023-09-14 20:01   ` Rodrigo Vivi
2023-08-14 22:40 ` [Intel-xe] ✓ CI.Patch_applied: success for Port CPU-GPU timestamp correlation to XE KMD Patchwork
2023-08-14 22:40 ` [Intel-xe] ✗ CI.checkpatch: warning " Patchwork
2023-08-14 22:41 ` [Intel-xe] ✓ CI.KUnit: success " Patchwork
2023-08-14 22:45 ` [Intel-xe] ✓ CI.Build: " Patchwork
2023-08-14 22:46 ` [Intel-xe] ✓ CI.Hooks: " Patchwork
2023-08-14 22:46 ` [Intel-xe] ✗ CI.checksparse: warning " Patchwork
2023-08-14 23:34 ` [Intel-xe] ✗ CI.BAT: failure " Patchwork
2023-08-15  1:51   ` Umesh Nerlige Ramappa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230814223734.375449-2-umesh.nerlige.ramappa@intel.com \
    --to=umesh.nerlige.ramappa@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=lionel.g.landwerlin@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox