Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Matt Atwood <matthew.s.atwood@intel.com>
To: intel-xe@lists.freedesktop.org, matthew.d.roper@intel.com,
	lucas.demarchi@intel.com
Subject: [Intel-xe] [PATCH 2/2 v3] drm/xe: add gt tuning for indirect state
Date: Wed, 23 Aug 2023 12:55:33 -0700	[thread overview]
Message-ID: <20230823195533.125633-2-matthew.s.atwood@intel.com> (raw)
In-Reply-To: <20230823195533.125633-1-matthew.s.atwood@intel.com>

Force indirect state sampler data to only be in the dynamic state pool,
which is more convienent for the UMD. Behavior change mirrors similar
change for i915 in commit 16fc9c08f0ec ("drm/i915: disable sampler
indirect state in bindless heap")

v2: split out per engine tuning into separate patch, commit message
(Lucas)
v3: rebase

Bspec: 46052

Signed-off-by: Matt Atwood <matthew.s.atwood@intel.com>
---
 drivers/gpu/drm/xe/regs/xe_gt_regs.h | 1 +
 drivers/gpu/drm/xe/xe_tuning.c       | 5 +++++
 2 files changed, 6 insertions(+)

diff --git a/drivers/gpu/drm/xe/regs/xe_gt_regs.h b/drivers/gpu/drm/xe/regs/xe_gt_regs.h
index aa9d7fad41ee..d039e7afe466 100644
--- a/drivers/gpu/drm/xe/regs/xe_gt_regs.h
+++ b/drivers/gpu/drm/xe/regs/xe_gt_regs.h
@@ -298,6 +298,7 @@
 #define   ENABLE_SMALLPL			REG_BIT(15)
 #define   SC_DISABLE_POWER_OPTIMIZATION_EBB	REG_BIT(9)
 #define   SAMPLER_ENABLE_HEADLESS_MSG		REG_BIT(5)
+#define   INDIRECT_STATE_BASE_ADDR_OVERRIDE	REG_BIT(0)
 
 #define HALF_SLICE_CHICKEN7				XE_REG_MCR(0xe194, XE_REG_OPTION_MASKED)
 #define   DG2_DISABLE_ROUND_ENABLE_ALLOW_FOR_SSLA	REG_BIT(15)
diff --git a/drivers/gpu/drm/xe/xe_tuning.c b/drivers/gpu/drm/xe/xe_tuning.c
index 702cb41dab53..07ffda39e2e4 100644
--- a/drivers/gpu/drm/xe/xe_tuning.c
+++ b/drivers/gpu/drm/xe/xe_tuning.c
@@ -28,6 +28,11 @@ static const struct xe_rtp_entry_sr gt_tunings[] = {
 };
 
 static const struct xe_rtp_entry_sr engine_tunings[] = {
+	{ XE_RTP_NAME("Tuning: Set Indirect State Override"),
+	  XE_RTP_RULES(GRAPHICS_VERSION_RANGE(1200, XE_RTP_END_VERSION_UNDEFINED),
+		       FUNC(xe_rtp_match_first_render_or_compute)),
+	  XE_RTP_ACTIONS(SET(SAMPLER_MODE, INDIRECT_STATE_BASE_ADDR_OVERRIDE))
+	},
 	{}
 };
 
-- 
2.40.1


  reply	other threads:[~2023-08-23 19:55 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-23 19:55 [Intel-xe] [PATCH 1/2 v3] drm/xe: Add infrastructure for per engine tuning Matt Atwood
2023-08-23 19:55 ` Matt Atwood [this message]
2023-08-24 20:35   ` [Intel-xe] [PATCH 2/2 v3] drm/xe: add gt tuning for indirect state Matt Roper
2023-09-06 21:39     ` Matt Atwood
2023-08-23 19:58 ` [Intel-xe] ✓ CI.Patch_applied: success for series starting with [1/2,v3] drm/xe: Add infrastructure for per engine tuning Patchwork
2023-08-23 19:58 ` [Intel-xe] ✗ CI.checkpatch: warning " Patchwork
2023-08-23 19:59 ` [Intel-xe] ✓ CI.KUnit: success " Patchwork
2023-08-23 20:03 ` [Intel-xe] ✓ CI.Build: " Patchwork
2023-08-23 20:04 ` [Intel-xe] ✓ CI.Hooks: " Patchwork
2023-08-23 20:04 ` [Intel-xe] ✗ CI.checksparse: warning " Patchwork
2023-08-23 20:31 ` [Intel-xe] ✗ CI.BAT: failure " Patchwork
2023-08-24 20:05 ` [Intel-xe] [PATCH 1/2 v3] " Matt Roper
2023-09-06 21:40   ` Matt Atwood

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230823195533.125633-2-matthew.s.atwood@intel.com \
    --to=matthew.s.atwood@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=lucas.demarchi@intel.com \
    --cc=matthew.d.roper@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox