From: Gustavo Sousa <gustavo.sousa@intel.com>
To: intel-xe@lists.freedesktop.org
Subject: [Intel-xe] [PATCH 1/1] fixup! drm/xe/display: Implement display support
Date: Fri, 8 Sep 2023 11:42:35 -0300 [thread overview]
Message-ID: <20230908144235.33628-2-gustavo.sousa@intel.com> (raw)
In-Reply-To: <20230908144235.33628-1-gustavo.sousa@intel.com>
Finalizer counterparts of display initializers are registered with
drmm_add_action_or_reset(). Since there are no other explicit users of
them outside of xe_display.c, let's turn them into static functions.
Signed-off-by: Gustavo Sousa <gustavo.sousa@intel.com>
---
drivers/gpu/drm/xe/xe_display.c | 6 +++---
drivers/gpu/drm/xe/xe_display.h | 15 +--------------
2 files changed, 4 insertions(+), 17 deletions(-)
diff --git a/drivers/gpu/drm/xe/xe_display.c b/drivers/gpu/drm/xe/xe_display.c
index a453946ad108..3d15d3ac431f 100644
--- a/drivers/gpu/drm/xe/xe_display.c
+++ b/drivers/gpu/drm/xe/xe_display.c
@@ -132,7 +132,7 @@ int xe_display_create(struct xe_device *xe)
return 0;
}
-void xe_display_fini_nommio(struct drm_device *dev, void *dummy)
+static void xe_display_fini_nommio(struct drm_device *dev, void *dummy)
{
struct xe_device *xe = to_xe_device(dev);
@@ -164,7 +164,7 @@ int xe_display_init_nommio(struct xe_device *xe)
return drmm_add_action_or_reset(&xe->drm, xe_display_fini_nommio, xe);
}
-void xe_display_fini_noirq(struct drm_device *dev, void *dummy)
+static void xe_display_fini_noirq(struct drm_device *dev, void *dummy)
{
struct xe_device *xe = to_xe_device(dev);
@@ -204,7 +204,7 @@ int xe_display_init_noirq(struct xe_device *xe)
return drmm_add_action_or_reset(&xe->drm, xe_display_fini_noirq, NULL);
}
-void xe_display_fini_noaccel(struct drm_device *dev, void *dummy)
+static void xe_display_fini_noaccel(struct drm_device *dev, void *dummy)
{
struct xe_device *xe = to_xe_device(dev);
diff --git a/drivers/gpu/drm/xe/xe_display.h b/drivers/gpu/drm/xe/xe_display.h
index 9e29de012df7..71e0bd27f1eb 100644
--- a/drivers/gpu/drm/xe/xe_display.h
+++ b/drivers/gpu/drm/xe/xe_display.h
@@ -20,13 +20,8 @@ int xe_display_create(struct xe_device *xe);
void xe_display_info_init(struct xe_device *xe);
int xe_display_init_nommio(struct xe_device *xe);
-void xe_display_fini_nommio(struct drm_device *dev, void *dummy);
-
int xe_display_init_noirq(struct xe_device *xe);
-void xe_display_fini_noirq(struct drm_device *dev, void *dummy);
-
int xe_display_init_noaccel(struct xe_device *xe);
-void xe_display_fini_noaccel(struct drm_device *dev, void *dummy);
int xe_display_init(struct xe_device *xe);
void xe_display_unlink(struct xe_device *xe);
@@ -60,17 +55,9 @@ static inline void xe_display_info_init(struct xe_device *xe) { }
static inline int
xe_display_enable(struct pci_dev *pdev, struct drm_driver *driver) { return 0; }
-static inline int
-xe_display_init_nommio(struct xe_device *xe) { return 0; }
-static inline void xe_display_fini_nommio(struct drm_device *dev, void *dummy) {}
-
+static inline int xe_display_init_nommio(struct xe_device *xe) { return 0; }
static inline int xe_display_init_noirq(struct xe_device *xe) { return 0; }
-
-static inline void
-xe_display_fini_noirq(struct drm_device *dev, void *dummy) {}
-
static inline int xe_display_init_noaccel(struct xe_device *xe) { return 0; }
-static inline void xe_display_fini_noaccel(struct drm_device *dev, void *dummy) {}
static inline int xe_display_init(struct xe_device *xe) { return 0; }
static inline void xe_display_unlink(struct xe_device *xe) {}
--
2.41.0
next prev parent reply other threads:[~2023-09-08 14:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-08 14:42 [Intel-xe] [PATCH 0/1] Turn display finalizers into static functions Gustavo Sousa
2023-09-08 14:42 ` Gustavo Sousa [this message]
2023-09-08 17:41 ` [Intel-xe] [PATCH 1/1] fixup! drm/xe/display: Implement display support Lucas De Marchi
2023-09-08 17:44 ` [Intel-xe] ✗ CI.Patch_applied: failure for Turn display finalizers into static functions (rev2) Patchwork
-- strict thread matches above, loose matches on Subject: below --
2023-09-08 18:49 [Intel-xe] [PATCH 0/1] Remove redundant call to intel_init_display_hooks() Gustavo Sousa
2023-09-08 18:49 ` [Intel-xe] [PATCH 1/1] fixup! drm/xe/display: Implement display support Gustavo Sousa
2023-09-21 6:50 ` Balasubramani Vivekanandan
2023-09-06 20:00 [Intel-xe] [PATCH 0/1] Return -EPROBE_DEFER from xe_display_driver_probe_defer() Gustavo Sousa
2023-09-06 20:00 ` [Intel-xe] [PATCH 1/1] fixup! drm/xe/display: Implement display support Gustavo Sousa
2023-09-06 20:49 ` Lucas De Marchi
2023-09-06 21:26 ` Gustavo Sousa
2023-07-04 16:09 [Intel-xe] [PATCH 0/1] Synchronize ext/intel_dram.c with the i915 source Lucas De Marchi
2023-07-04 16:09 ` [Intel-xe] [PATCH 1/1] fixup! drm/xe/display: Implement display support Lucas De Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230908144235.33628-2-gustavo.sousa@intel.com \
--to=gustavo.sousa@intel.com \
--cc=intel-xe@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox