From: Tejas Upadhyay <tejas.upadhyay@intel.com>
To: intel-xe@lists.freedesktop.org
Subject: [Intel-xe] [PATCH V2 5/7] drm/xe: Track page table memory usage for client
Date: Tue, 12 Sep 2023 17:22:37 +0530 [thread overview]
Message-ID: <20230912115239.3554341-6-tejas.upadhyay@intel.com> (raw)
In-Reply-To: <20230912115239.3554341-1-tejas.upadhyay@intel.com>
Account page table memory usage in the owning client
memory usage stats.
V2:
- Minor tweak to if (vm->pt_root[id]) check - Himal
Signed-off-by: Tejas Upadhyay <tejas.upadhyay@intel.com>
---
drivers/gpu/drm/xe/xe_pt.c | 4 +++-
drivers/gpu/drm/xe/xe_vm.c | 7 ++++++-
2 files changed, 9 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/xe/xe_pt.c b/drivers/gpu/drm/xe/xe_pt.c
index 5709518e314b..8df83241c5fe 100644
--- a/drivers/gpu/drm/xe/xe_pt.c
+++ b/drivers/gpu/drm/xe/xe_pt.c
@@ -7,6 +7,7 @@
#include "xe_bo.h"
#include "xe_device.h"
+#include "xe_drm_client.h"
#include "xe_gt.h"
#include "xe_gt_tlb_invalidation.h"
#include "xe_migrate.h"
@@ -195,7 +196,8 @@ struct xe_pt *xe_pt_create(struct xe_vm *vm, struct xe_tile *tile,
pt->bo = bo;
pt->level = level;
pt->base.dir = level ? &as_xe_pt_dir(pt)->dir : NULL;
-
+ if (vm->xef)
+ xe_drm_client_add_bo(vm->xef->client, pt->bo);
XE_WARN_ON(level > XE_VM_MAX_LEVEL);
return pt;
diff --git a/drivers/gpu/drm/xe/xe_vm.c b/drivers/gpu/drm/xe/xe_vm.c
index 92d8c78c9284..4eae641fc79f 100644
--- a/drivers/gpu/drm/xe/xe_vm.c
+++ b/drivers/gpu/drm/xe/xe_vm.c
@@ -19,6 +19,7 @@
#include "xe_bo.h"
#include "xe_device.h"
+#include "xe_drm_client.h"
#include "xe_exec_queue.h"
#include "xe_gt.h"
#include "xe_gt_pagefault.h"
@@ -1974,6 +1975,7 @@ int xe_vm_create_ioctl(struct drm_device *dev, void *data,
struct xe_device *xe = to_xe_device(dev);
struct xe_file *xef = to_xe_file(file);
struct drm_xe_vm_create *args = data;
+ struct xe_tile *tile;
struct xe_vm *vm;
u32 id, asid;
int err;
@@ -2052,7 +2054,10 @@ int xe_vm_create_ioctl(struct drm_device *dev, void *data,
args->vm_id = id;
vm->xef = xef;
-
+ /* Record BO memory for VM pagetable create against client */
+ for_each_tile(tile, xe, id)
+ if (vm->pt_root[id])
+ xe_drm_client_add_bo(vm->xef->client, vm->pt_root[id]->bo);
#if IS_ENABLED(CONFIG_DRM_XE_DEBUG_MEM)
/* Warning: Security issue - never enable by default */
args->reserved[0] = xe_bo_main_addr(vm->pt_root[0]->bo, XE_PAGE_SIZE);
--
2.25.1
next prev parent reply other threads:[~2023-09-12 11:45 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-12 11:52 [Intel-xe] [PATCH V2 0/7] drm/xe: fdinfo memory stats Tejas Upadhyay
2023-09-12 11:52 ` [Intel-xe] [PATCH V2 1/7] drm/xe: Add drm-client infrastructure Tejas Upadhyay
2023-09-12 11:52 ` [Intel-xe] [PATCH V2 2/7] drm/xe: Interface xe drm client with fdinfo interface Tejas Upadhyay
2023-09-12 11:52 ` [Intel-xe] [PATCH V2 3/7] drm/xe: Add tracking support for bos per client Tejas Upadhyay
2023-09-13 8:39 ` Ghimiray, Himal Prasad
2023-09-12 11:52 ` [Intel-xe] [PATCH V2 4/7] drm/xe: Record each drm client with its VM Tejas Upadhyay
2023-09-13 8:58 ` Ghimiray, Himal Prasad
2023-09-12 11:52 ` Tejas Upadhyay [this message]
2023-09-13 8:38 ` [Intel-xe] [PATCH V2 5/7] drm/xe: Track page table memory usage for client Ghimiray, Himal Prasad
2023-09-12 11:52 ` [Intel-xe] [PATCH V2 6/7] drm/xe: Account ring buffer and context state storage Tejas Upadhyay
2023-09-12 11:52 ` [Intel-xe] [PATCH V2 7/7] drm/xe: Implement fdinfo memory stats printing Tejas Upadhyay
2023-09-12 12:06 ` [Intel-xe] ✓ CI.Patch_applied: success for drm/xe: fdinfo memory stats (rev2) Patchwork
2023-09-12 12:07 ` [Intel-xe] ✗ CI.checkpatch: warning " Patchwork
2023-09-12 12:08 ` [Intel-xe] ✓ CI.KUnit: success " Patchwork
2023-09-12 12:15 ` [Intel-xe] ✓ CI.Build: " Patchwork
2023-09-12 12:15 ` [Intel-xe] ✓ CI.Hooks: " Patchwork
2023-09-12 12:17 ` [Intel-xe] ✓ CI.checksparse: " Patchwork
2023-09-12 12:49 ` [Intel-xe] ✓ CI.BAT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230912115239.3554341-6-tejas.upadhyay@intel.com \
--to=tejas.upadhyay@intel.com \
--cc=intel-xe@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox