From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0132CCA0EEB for ; Tue, 12 Sep 2023 14:53:09 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B847B10E42A; Tue, 12 Sep 2023 14:53:09 +0000 (UTC) Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by gabe.freedesktop.org (Postfix) with ESMTPS id D922910E0C5; Tue, 12 Sep 2023 14:53:05 +0000 (UTC) Received: from localhost (unknown [IPv6:2a01:e0a:2c:6930:5cf4:84a1:2763:fe0d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: bbrezillon) by madras.collabora.co.uk (Postfix) with ESMTPSA id F0EC7660731A; Tue, 12 Sep 2023 15:53:03 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1694530384; bh=7pr9nMqLHgNUUEvsRR36/rZ7W75CUex4/e4+WtNgODQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=W1JlRr7ZqTtrqtPq9UvfB55AWW8DHUya1n0XdpJpzvbupm158eoNpRzxdrVPhY7Wf 6FXh+M9goXKsyjADR6lhumJhqOhe2Fr+bZRCxLYHtmZu4502pL24sudQQjShWzLNTo 7S2OEtDufIEWwMCy6DxmiLjZxpQ0adpCDCXeQM1NUhRK6g9q6T/Z0ArZ0tcgHr07S4 sJ6sPDC/CRXJutCsYFVv4zwH6CmPPbOEaPhy374DpHPlK23ro28AL/pSL4yJhpFEeK 06XO04sf3f1v6YGADtyZjktt4uZnDi1F5+n6v2ZnE14CyYRdbRYp/b1r10C/YqvvoF ZB5RhOGWCfHzw== Date: Tue, 12 Sep 2023 16:53:00 +0200 From: Boris Brezillon To: Matthew Brost Message-ID: <20230912165300.53c1a151@collabora.com> In-Reply-To: References: <20230912021615.2086698-1-matthew.brost@intel.com> <20230912021615.2086698-6-matthew.brost@intel.com> <20230912100833.792eacb6@collabora.com> Organization: Collabora X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Intel-xe] [PATCH v3 05/13] drm/sched: Split free_job into own work item X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: robdclark@chromium.org, sarah.walker@imgtec.com, ketil.johnsen@arm.com, Liviu.Dudau@arm.com, mcanal@igalia.com, frank.binns@imgtec.com, dri-devel@lists.freedesktop.org, christian.koenig@amd.com, luben.tuikov@amd.com, donald.robson@imgtec.com, daniel@ffwll.ch, lina@asahilina.net, airlied@gmail.com, intel-xe@lists.freedesktop.org, faith.ekstrand@collabora.com Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Tue, 12 Sep 2023 14:37:57 +0000 Matthew Brost wrote: > > Looks like you are changing the behavior here (unconditional -> > > conditional timestamp update)? Probably something that should go in a > > separate patch. > > > > This patch creates a race so this check isn't need before this patch. > With that I think it makes sense to have all in a single patch. If you > feel strongly about this, I can break this change out into a patch prior > to this one. It's probably fine to keep it in this patch, but we should definitely have a comment explaining why this check is needed.