Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Matt Roper <matthew.d.roper@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: Lucas De Marchi <lucas.demarchi@intel.com>, matthew.d.roper@intel.com
Subject: [Intel-xe] [PATCH 0/6] Separate display and tile workarounds
Date: Wed, 13 Sep 2023 16:14:12 -0700	[thread overview]
Message-ID: <20230913231411.291933-8-matthew.d.roper@intel.com> (raw)

i915's "clock gating" hooks were historically a bit of a dumping ground
for assorted register programming (some of which wasn't actually related
to clock gating in any way).  i915 has now moved display workarounds to
their own area within the display-specific code, so cherry-picking those
patches into the Xe kernel will ensure that the same display workarounds
are applied automatically during Xe's display init.

With display workarounds taken care of by the i915 cherry-picks, the
remaining "clock gating" programming that Xe needs is more accurately
described as "tile workarounds," i.e., workarounds that target
sgunit/soc registers outside of the GTs and the display.  Such
workarounds are very rare and if we disregard pre-production
workarounds, there's only a single tile workaround needed on Xe today.
Adding proper programming for tile workarounds to Xe and moving
Wa_22010954014 to that new area allows us to drop
ext/intel_clock_gating.c.

Cc: Lucas De Marchi <lucas.demarchi@intel.com>
Cc: Jani Nikula <jani.nikula@linux.intel.com>

Matt Roper (6):
  drm/i915: Stop forcing clock gating init for future platforms
  drm/i915/adlp: Stop calling gen12lp_init_clock_gating()
  drm/i915/display: Extract display workarounds from clock gating init
  drm/i915/display: Apply workarounds during display init
  drm/xe/wa: Apply tile workarounds at probe/resume
  fixup! drm/xe/display: Implement display support

 drivers/gpu/drm/i915/Makefile                 |   1 +
 .../drm/i915/display/intel_display_driver.c   |   3 +
 .../gpu/drm/i915/display/intel_display_wa.c   |  48 +++++++
 .../gpu/drm/i915/display/intel_display_wa.h   |  13 ++
 drivers/gpu/drm/i915/intel_clock_gating.c     |  52 +-------
 drivers/gpu/drm/xe/Makefile                   |   4 +-
 .../drm/xe/display/ext/intel_clock_gating.c   | 124 ------------------
 drivers/gpu/drm/xe/regs/xe_regs.h             |   3 +
 drivers/gpu/drm/xe/xe_display.c               |   2 -
 drivers/gpu/drm/xe/xe_pm.c                    |   5 +
 drivers/gpu/drm/xe/xe_tile.c                  |   3 +
 drivers/gpu/drm/xe/xe_wa.c                    |  20 +++
 drivers/gpu/drm/xe/xe_wa.h                    |   2 +
 drivers/gpu/drm/xe/xe_wa_oob.rules            |   1 +
 14 files changed, 103 insertions(+), 178 deletions(-)
 create mode 100644 drivers/gpu/drm/i915/display/intel_display_wa.c
 create mode 100644 drivers/gpu/drm/i915/display/intel_display_wa.h
 delete mode 100644 drivers/gpu/drm/xe/display/ext/intel_clock_gating.c

-- 
2.41.0


             reply	other threads:[~2023-09-13 23:15 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-13 23:14 Matt Roper [this message]
2023-09-13 23:14 ` [Intel-xe] [PATCH 1/6] drm/i915: Stop forcing clock gating init for future platforms Matt Roper
2023-09-13 23:14 ` [Intel-xe] [PATCH 2/6] drm/i915/adlp: Stop calling gen12lp_init_clock_gating() Matt Roper
2023-09-13 23:14 ` [Intel-xe] [PATCH 3/6] drm/i915/display: Extract display workarounds from clock gating init Matt Roper
2023-09-13 23:14 ` [Intel-xe] [PATCH 4/6] drm/i915/display: Apply workarounds during display init Matt Roper
2023-09-13 23:14 ` [Intel-xe] [PATCH 5/6] drm/xe/wa: Apply tile workarounds at probe/resume Matt Roper
2023-09-18 17:11   ` Lucas De Marchi
2023-09-19 22:31     ` Matt Roper
2023-09-20 13:34       ` Lucas De Marchi
2023-09-13 23:14 ` [Intel-xe] [PATCH 6/6] fixup! drm/xe/display: Implement display support Matt Roper
2023-09-20 13:42   ` Lucas De Marchi
2023-09-13 23:17 ` [Intel-xe] ✓ CI.Patch_applied: success for Separate display and tile workarounds Patchwork
2023-09-13 23:17 ` [Intel-xe] ✗ CI.checkpatch: warning " Patchwork
2023-09-13 23:18 ` [Intel-xe] ✓ CI.KUnit: success " Patchwork
2023-09-13 23:25 ` [Intel-xe] ✓ CI.Build: " Patchwork
2023-09-13 23:26 ` [Intel-xe] ✓ CI.Hooks: " Patchwork
2023-09-13 23:27 ` [Intel-xe] ✗ CI.checksparse: warning " Patchwork
2023-09-13 23:59 ` [Intel-xe] ✓ CI.BAT: success " Patchwork
2023-09-14  8:17 ` [Intel-xe] [PATCH 0/6] " Jani Nikula

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230913231411.291933-8-matthew.d.roper@intel.com \
    --to=matthew.d.roper@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=lucas.demarchi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox