From: "Jouni Högander" <jouni.hogander@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: "Jouni Högander" <jouni.hogander@intel.com>
Subject: [Intel-xe] [PATCH 2/7] fixup! FIXME: drm/i915/display: Remaining changes to make xe compile
Date: Fri, 15 Sep 2023 10:48:13 +0300 [thread overview]
Message-ID: <20230915074818.903353-3-jouni.hogander@intel.com> (raw)
In-Reply-To: <20230915074818.903353-1-jouni.hogander@intel.com>
Generic dirtyfb implementation which Xe is currently using is doing atomic
commit which is inefficient. We have now dma fence handling in our dirtyfb
implementation. This works with Xe and CPU/GPU frontbuffer rendering as
long as sync objects are imported by userspace
(dma_buf_import_sync_file). Switch to our custom dirtyfb implementation.
Signed-off-by: Jouni Högander <jouni.hogander@intel.com>
---
drivers/gpu/drm/i915/display/intel_fb.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_fb.c b/drivers/gpu/drm/i915/display/intel_fb.c
index f5a96b94cfba..8891ff14a446 100644
--- a/drivers/gpu/drm/i915/display/intel_fb.c
+++ b/drivers/gpu/drm/i915/display/intel_fb.c
@@ -1930,7 +1930,6 @@ static int intel_user_framebuffer_create_handle(struct drm_framebuffer *fb,
return drm_gem_handle_create(file, &obj->ttm.base, handle);
}
-#ifdef I915
static int intel_user_framebuffer_dirty(struct drm_framebuffer *fb,
struct drm_file *file,
unsigned int flags, unsigned int color,
@@ -1944,16 +1943,11 @@ static int intel_user_framebuffer_dirty(struct drm_framebuffer *fb,
return 0;
}
-#endif
static const struct drm_framebuffer_funcs intel_fb_funcs = {
.destroy = intel_user_framebuffer_destroy,
.create_handle = intel_user_framebuffer_create_handle,
-#ifdef I915
.dirty = intel_user_framebuffer_dirty,
-#else
- .dirty = drm_atomic_helper_dirtyfb,
-#endif
};
int intel_framebuffer_init(struct intel_framebuffer *intel_fb,
--
2.34.1
next prev parent reply other threads:[~2023-09-15 7:49 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-15 7:48 [Intel-xe] [PATCH 0/7] Frontbuffer tracking and dirtyfb Jouni Högander
2023-09-15 7:48 ` [Intel-xe] [PATCH 1/7] drm/xe: Add empty def for i915_gem_object_flush_if_display Jouni Högander
2023-09-15 7:48 ` Jouni Högander [this message]
2023-09-15 7:48 ` [Intel-xe] [PATCH 3/7] drm/i915/fbc: Clear frontbuffer busy bits on flip Jouni Högander
2023-09-15 7:48 ` [Intel-xe] [PATCH 4/7] drm/i915/psr: " Jouni Högander
2023-09-15 7:48 ` [Intel-xe] [PATCH 5/7] drm/i915: Add new frontbuffer tracking interface to queue flush Jouni Högander
2023-09-15 7:48 ` [Intel-xe] [PATCH 6/7] drm/i915: Handle dma fences in dirtyfb callback Jouni Högander
2023-09-15 7:48 ` [Intel-xe] [PATCH 7/7] drm/i915/display: Use intel_bo_to_drm_bo instead of obj->base Jouni Högander
2023-09-15 7:56 ` [Intel-xe] ✓ CI.Patch_applied: success for Frontbuffer tracking and dirtyfb Patchwork
2023-09-15 7:56 ` [Intel-xe] ✓ CI.checkpatch: " Patchwork
2023-09-15 7:57 ` [Intel-xe] ✓ CI.KUnit: " Patchwork
2023-09-15 8:04 ` [Intel-xe] ✓ CI.Build: " Patchwork
2023-09-15 8:05 ` [Intel-xe] ✗ CI.Hooks: failure " Patchwork
2023-09-15 8:06 ` [Intel-xe] ✗ CI.checksparse: warning " Patchwork
2023-09-15 8:38 ` [Intel-xe] ✓ CI.BAT: success " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230915074818.903353-3-jouni.hogander@intel.com \
--to=jouni.hogander@intel.com \
--cc=intel-xe@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox