Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
To: intel-xe@lists.freedesktop.org
Subject: [Intel-xe] [PATCH 2/3] drm/i915: Swap ggtt_vma during legacy cursor update
Date: Fri, 15 Sep 2023 19:36:45 +0200	[thread overview]
Message-ID: <20230915173646.116724-2-maarten.lankhorst@linux.intel.com> (raw)
In-Reply-To: <20230915173646.116724-1-maarten.lankhorst@linux.intel.com>

Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
---
 drivers/gpu/drm/i915/display/intel_cursor.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_cursor.c b/drivers/gpu/drm/i915/display/intel_cursor.c
index 8ed8a623fa98b..b1a77b89585d5 100644
--- a/drivers/gpu/drm/i915/display/intel_cursor.c
+++ b/drivers/gpu/drm/i915/display/intel_cursor.c
@@ -690,9 +690,8 @@ intel_legacy_cursor_update(struct drm_plane *_plane,
 	if (ret)
 		goto out_free;
 
-	ret = intel_plane_pin_fb(new_plane_state);
-	if (ret)
-		goto out_free;
+	/* magic trick! */
+	swap(new_plane_state->ggtt_vma, old_plane_state->ggtt_vma);
 
 	intel_frontbuffer_flush(to_intel_frontbuffer(new_plane_state->hw.fb),
 				ORIGIN_CURSOR_UPDATE);
-- 
2.39.2


  reply	other threads:[~2023-09-15 17:36 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-15 17:36 [Intel-xe] [PATCH 1/3] fixup! drm/xe/display: Implement display support Maarten Lankhorst
2023-09-15 17:36 ` Maarten Lankhorst [this message]
2023-09-15 17:36 ` [Intel-xe] [PATCH 3/3] drm/i915: Block in cleanup for legacy cursor updates Maarten Lankhorst
2023-09-20 20:06   ` Rodrigo Vivi
2023-09-15 18:13 ` [Intel-xe] ✓ CI.Patch_applied: success for series starting with [1/3] fixup! drm/xe/display: Implement display support Patchwork
2023-09-15 18:14 ` [Intel-xe] ✗ CI.checkpatch: warning " Patchwork
2023-09-15 18:15 ` [Intel-xe] ✓ CI.KUnit: success " Patchwork
2023-09-15 18:22 ` [Intel-xe] ✓ CI.Build: " Patchwork
2023-09-15 18:22 ` [Intel-xe] ✗ CI.Hooks: failure " Patchwork
2023-09-15 18:23 ` [Intel-xe] ✗ CI.checksparse: warning " Patchwork
2023-09-15 18:55 ` [Intel-xe] ✓ CI.BAT: success " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230915173646.116724-2-maarten.lankhorst@linux.intel.com \
    --to=maarten.lankhorst@linux.intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox