From: Ville Syrjala <ville.syrjala@linux.intel.com>
To: intel-xe@lists.freedesktop.org
Subject: [Intel-xe] [PATCH 3/3] maybe xe is broken enough that it gives you a new vma every time?
Date: Wed, 20 Sep 2023 17:03:39 +0300 [thread overview]
Message-ID: <20230920140339.28322-3-ville.syrjala@linux.intel.com> (raw)
In-Reply-To: <20230920140339.28322-1-ville.syrjala@linux.intel.com>
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/i915/display/intel_cursor.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_cursor.c b/drivers/gpu/drm/i915/display/intel_cursor.c
index afe1d0fa0537..ab6a56ed40a9 100644
--- a/drivers/gpu/drm/i915/display/intel_cursor.c
+++ b/drivers/gpu/drm/i915/display/intel_cursor.c
@@ -752,7 +752,8 @@ intel_legacy_cursor_update(struct drm_plane *_plane,
local_irq_enable();
- if (old_plane_state->hw.fb != new_plane_state->hw.fb) {
+ if (old_plane_state->ggtt_vma != new_plane_state->ggtt_vma) {
+ drm_WARN_ON_ONCE(plane->base.dev, old_plane_state->hw.fb == new_plane_state->hw.fb);
drm_vblank_work_init(&old_plane_state->unpin_work, &crtc->base,
intel_cursor_unpin_work);
--
2.41.0
next prev parent reply other threads:[~2023-09-20 14:03 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-20 14:03 [Intel-xe] [PATCH 1/3] drm/i915: Use vblank worker to unpin old legacy cursor fb safely Ville Syrjala
2023-09-20 14:03 ` [Intel-xe] [PATCH 2/3] drm/vblank: Warn when silently cancelling vblank works Ville Syrjala
2023-09-20 19:55 ` Lyude Paul
2023-10-03 13:34 ` Ville Syrjälä
2023-09-20 14:03 ` Ville Syrjala [this message]
2023-09-20 17:27 ` [Intel-xe] [PATCH v2 3/3] maybe xe is broken enough that it gives you a new vma every time? Ville Syrjala
2023-09-20 14:06 ` [Intel-xe] ✓ CI.Patch_applied: success for series starting with [1/3] drm/i915: Use vblank worker to unpin old legacy cursor fb safely Patchwork
2023-09-20 14:06 ` [Intel-xe] ✗ CI.checkpatch: warning " Patchwork
2023-09-20 14:07 ` [Intel-xe] ✓ CI.KUnit: success " Patchwork
2023-09-20 14:14 ` [Intel-xe] ✓ CI.Build: " Patchwork
2023-09-20 14:15 ` [Intel-xe] ✓ CI.Hooks: " Patchwork
2023-09-20 14:16 ` [Intel-xe] ✗ CI.checksparse: warning " Patchwork
2023-09-20 14:48 ` [Intel-xe] ✗ CI.BAT: failure " Patchwork
2023-09-20 18:45 ` [Intel-xe] ✓ CI.Patch_applied: success for series starting with [1/3] drm/i915: Use vblank worker to unpin old legacy cursor fb safely (rev2) Patchwork
2023-09-20 18:45 ` [Intel-xe] ✗ CI.checkpatch: warning " Patchwork
2023-09-20 18:46 ` [Intel-xe] ✓ CI.KUnit: success " Patchwork
2023-09-20 18:53 ` [Intel-xe] ✓ CI.Build: " Patchwork
2023-09-20 18:54 ` [Intel-xe] ✓ CI.Hooks: " Patchwork
2023-09-20 18:55 ` [Intel-xe] ✗ CI.checksparse: warning " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230920140339.28322-3-ville.syrjala@linux.intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=intel-xe@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox