Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Vinod Govindapillai <vinod.govindapillai@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: matthew.d.roper@intel.com, intel-gfx@lists.freedesktop.org,
	ville.syrjala@intel.com
Subject: [Intel-xe] [PATCH v5 2/2] drm/i915/lnl: update the supported plane formats with FBC
Date: Fri, 22 Sep 2023 16:30:03 +0300	[thread overview]
Message-ID: <20230922133003.150578-3-vinod.govindapillai@intel.com> (raw)
In-Reply-To: <20230922133003.150578-1-vinod.govindapillai@intel.com>

FBC is supported with RGB32 8:8:8:8 with or without alpha

Bspec: 68904, 69560
Signed-off-by: Vinod Govindapillai <vinod.govindapillai@intel.com>
---
 drivers/gpu/drm/i915/display/intel_fbc.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/display/intel_fbc.c b/drivers/gpu/drm/i915/display/intel_fbc.c
index aef5a4f6ad09..9b19fe018bce 100644
--- a/drivers/gpu/drm/i915/display/intel_fbc.c
+++ b/drivers/gpu/drm/i915/display/intel_fbc.c
@@ -903,6 +903,11 @@ static bool pixel_format_is_valid(const struct intel_plane_state *plane_state)
 		if (IS_G4X(i915))
 			return false;
 		return true;
+	case DRM_FORMAT_ARGB8888:
+	case DRM_FORMAT_ABGR8888:
+		if (DISPLAY_VER(i915) >= 20)
+			return true;
+		fallthrough;
 	default:
 		return false;
 	}
@@ -1132,7 +1137,8 @@ static int intel_fbc_check_plane(struct intel_atomic_state *state,
 		return 0;
 	}
 
-	if (plane_state->hw.pixel_blend_mode != DRM_MODE_BLEND_PIXEL_NONE &&
+	if (DISPLAY_VER(i915) < 20 &&
+	    plane_state->hw.pixel_blend_mode != DRM_MODE_BLEND_PIXEL_NONE &&
 	    fb->format->has_alpha) {
 		plane_state->no_fbc_reason = "per-pixel alpha not supported";
 		return 0;
-- 
2.34.1


  parent reply	other threads:[~2023-09-22 13:31 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-22 13:30 [Intel-xe] [PATCH v5 0/2] fbc on any planes Vinod Govindapillai
2023-09-22 13:30 ` [Intel-xe] [PATCH v5 1/2] drm/i915/lnl: possibility to enable FBC on first three planes Vinod Govindapillai
2023-09-22 13:30 ` Vinod Govindapillai [this message]
2023-09-22 15:58 ` [Intel-xe] ✓ CI.Patch_applied: success for fbc on any planes Patchwork
2023-09-22 15:58 ` [Intel-xe] ✗ CI.checkpatch: warning " Patchwork
2023-09-22 15:59 ` [Intel-xe] ✓ CI.KUnit: success " Patchwork
2023-09-25 12:16 ` [Intel-xe] [PATCH v5 0/2] " Jani Nikula
2023-09-25 13:01   ` Govindapillai, Vinod
2023-10-03 12:58 ` Ville Syrjälä

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230922133003.150578-3-vinod.govindapillai@intel.com \
    --to=vinod.govindapillai@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=matthew.d.roper@intel.com \
    --cc=ville.syrjala@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox