Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Jouni Högander" <jouni.hogander@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: "Jouni Högander" <jouni.hogander@intel.com>
Subject: [Intel-xe] [PATCH 1/2] Revert "drm/i915: Ignore set frontbuffer return value on release"
Date: Fri, 29 Sep 2023 13:50:29 +0300	[thread overview]
Message-ID: <20230929105030.1132290-2-jouni.hogander@intel.com> (raw)
In-Reply-To: <20230929105030.1132290-1-jouni.hogander@intel.com>

This reverts commit 93f635ae20cce2b9ee9b647ef986615552ae28d1.

Next patch is backporting equivalent patch from upstream -> revert
this one.

Signed-off-by: Jouni Högander <jouni.hogander@intel.com>
---
 drivers/gpu/drm/i915/display/intel_frontbuffer.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/display/intel_frontbuffer.c b/drivers/gpu/drm/i915/display/intel_frontbuffer.c
index e6fb777dc374..21fb5660d977 100644
--- a/drivers/gpu/drm/i915/display/intel_frontbuffer.c
+++ b/drivers/gpu/drm/i915/display/intel_frontbuffer.c
@@ -232,7 +232,8 @@ static void frontbuffer_release(struct kref *ref)
 	drm_WARN_ON(&intel_bo_to_i915(obj)->drm, atomic_read(&front->bits));
 
 	i915_ggtt_clear_scanout(obj);
-	(void) i915_gem_object_set_frontbuffer(obj, NULL);
+
+	i915_gem_object_set_frontbuffer(obj, NULL);
 	spin_unlock(&intel_bo_to_i915(obj)->display.fb_tracking.lock);
 
 	i915_active_fini(&front->write);
-- 
2.34.1


  reply	other threads:[~2023-09-29 10:51 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-29 10:50 [Intel-xe] [PATCH 0/2] Backport set frontbuffer return value check Jouni Högander
2023-09-29 10:50 ` Jouni Högander [this message]
2023-09-29 10:50 ` [Intel-xe] [PATCH 2/2] drm/i915: Warn on if set frontbuffer return value is not NULL on release Jouni Högander
2023-09-29 10:59 ` [Intel-xe] ✓ CI.Patch_applied: success for Backport set frontbuffer return value check Patchwork
2023-09-29 10:59 ` [Intel-xe] ✗ CI.checkpatch: warning " Patchwork
2023-09-29 11:01 ` [Intel-xe] ✓ CI.KUnit: success " Patchwork
2023-09-29 11:05 ` [Intel-xe] [PATCH 0/2] " Jani Nikula
2023-09-29 11:08 ` [Intel-xe] ✓ CI.Build: success for " Patchwork
2023-09-29 11:08 ` [Intel-xe] ✓ CI.Hooks: " Patchwork
2023-09-29 11:09 ` [Intel-xe] ✗ CI.checksparse: warning " Patchwork
2023-09-29 11:42 ` [Intel-xe] ✓ CI.BAT: success " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230929105030.1132290-2-jouni.hogander@intel.com \
    --to=jouni.hogander@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox