From: Michal Wajdeczko <michal.wajdeczko@intel.com>
To: intel-xe@lists.freedesktop.org
Subject: [Intel-xe] [PATCH 5/5] drm/xe/kunit: Add test for LMTT operations
Date: Tue, 28 Nov 2023 16:15:07 +0100 [thread overview]
Message-ID: <20231128151507.1015-6-michal.wajdeczko@intel.com> (raw)
In-Reply-To: <20231128151507.1015-1-michal.wajdeczko@intel.com>
The LMTT variants are abstracted with xe_lmtt_ops. Make sure that
both 2L and ML ops implementations are correct.
Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
---
drivers/gpu/drm/xe/tests/xe_lmtt_test.c | 73 +++++++++++++++++++++++++
drivers/gpu/drm/xe/xe_lmtt.c | 4 ++
2 files changed, 77 insertions(+)
create mode 100644 drivers/gpu/drm/xe/tests/xe_lmtt_test.c
diff --git a/drivers/gpu/drm/xe/tests/xe_lmtt_test.c b/drivers/gpu/drm/xe/tests/xe_lmtt_test.c
new file mode 100644
index 000000000000..1f1557c45ae1
--- /dev/null
+++ b/drivers/gpu/drm/xe/tests/xe_lmtt_test.c
@@ -0,0 +1,73 @@
+// SPDX-License-Identifier: GPL-2.0 AND MIT
+/*
+ * Copyright © 2023 Intel Corporation
+ */
+
+#include <kunit/test.h>
+
+static const struct lmtt_ops_param {
+ const char *desc;
+ const struct xe_lmtt_ops *ops;
+} lmtt_ops_params[] = {
+ { "2-level", &lmtt_2l_ops, },
+ { "multi-level", &lmtt_ml_ops, },
+};
+
+static void lmtt_ops_param_get_desc(const struct lmtt_ops_param *p, char *desc)
+{
+ snprintf(desc, KUNIT_PARAM_DESC_SIZE, "%s", p->desc);
+}
+
+KUNIT_ARRAY_PARAM(lmtt_ops, lmtt_ops_params, lmtt_ops_param_get_desc);
+
+static void test_ops(struct kunit *test)
+{
+ const struct lmtt_ops_param *p = test->param_value;
+ const struct xe_lmtt_ops *ops = p->ops;
+ unsigned int n;
+
+ KUNIT_ASSERT_NOT_NULL(test, ops->lmtt_root_pd_level);
+ KUNIT_ASSERT_NOT_NULL(test, ops->lmtt_pte_num);
+ KUNIT_ASSERT_NOT_NULL(test, ops->lmtt_pte_size);
+ KUNIT_ASSERT_NOT_NULL(test, ops->lmtt_pte_shift);
+ KUNIT_ASSERT_NOT_NULL(test, ops->lmtt_pte_index);
+ KUNIT_ASSERT_NOT_NULL(test, ops->lmtt_pte_encode);
+
+ KUNIT_EXPECT_NE(test, ops->lmtt_root_pd_level(), 0);
+
+ for (n = 0; n <= ops->lmtt_root_pd_level(); n++) {
+ KUNIT_EXPECT_NE_MSG(test, ops->lmtt_pte_num(n), 0,
+ "level=%u", n);
+ KUNIT_EXPECT_NE_MSG(test, ops->lmtt_pte_size(n), 0,
+ "level=%u", n);
+ KUNIT_EXPECT_NE_MSG(test, ops->lmtt_pte_encode(0, n), LMTT_PTE_INVALID,
+ "level=%u", n);
+ }
+
+ for (n = 0; n < ops->lmtt_root_pd_level(); n++) {
+ u64 addr = BIT_ULL(ops->lmtt_pte_shift(n));
+
+ KUNIT_EXPECT_NE_MSG(test, ops->lmtt_pte_shift(n), 0,
+ "level=%u", n);
+ KUNIT_EXPECT_EQ_MSG(test, ops->lmtt_pte_index(addr - 1, n), 0,
+ "addr=%#llx level=%u", addr, n);
+ KUNIT_EXPECT_EQ_MSG(test, ops->lmtt_pte_index(addr + 1, n), 1,
+ "addr=%#llx level=%u", addr, n);
+ KUNIT_EXPECT_EQ_MSG(test, ops->lmtt_pte_index(addr * 2 - 1, n), 1,
+ "addr=%#llx level=%u", addr, n);
+ KUNIT_EXPECT_EQ_MSG(test, ops->lmtt_pte_index(addr * 2, n), 2,
+ "addr=%#llx level=%u", addr, n);
+ }
+}
+
+static struct kunit_case lmtt_test_cases[] = {
+ KUNIT_CASE_PARAM(test_ops, lmtt_ops_gen_params),
+ {}
+};
+
+static struct kunit_suite lmtt_suite = {
+ .name = "lmtt",
+ .test_cases = lmtt_test_cases,
+};
+
+kunit_test_suites(&lmtt_suite);
diff --git a/drivers/gpu/drm/xe/xe_lmtt.c b/drivers/gpu/drm/xe/xe_lmtt.c
index d5ada31ae633..0d7c5514e092 100644
--- a/drivers/gpu/drm/xe/xe_lmtt.c
+++ b/drivers/gpu/drm/xe/xe_lmtt.c
@@ -500,3 +500,7 @@ u64 xe_lmtt_estimate_pt_size(struct xe_lmtt *lmtt, u64 size)
return pt_size;
}
+
+#if IS_BUILTIN(CONFIG_DRM_XE_KUNIT_TEST)
+#include "tests/xe_lmtt_test.c"
+#endif
--
2.25.1
next prev parent reply other threads:[~2023-11-28 15:15 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-28 15:15 [Intel-xe] [PATCH 0/5] Introduce Local Memory Translation Table Michal Wajdeczko
2023-11-28 15:15 ` [Intel-xe] [PATCH 1/5] drm/xe: Define DRM_XE_DEBUG_SRIOV config Michal Wajdeczko
2023-12-07 14:17 ` Lucas De Marchi
2023-11-28 15:15 ` [Intel-xe] [PATCH 2/5] drm/xe: Introduce SR-IOV logging macros Michal Wajdeczko
2023-12-07 14:17 ` Lucas De Marchi
2023-11-28 15:15 ` [Intel-xe] [PATCH 3/5] drm/xe/pf: Introduce Local Memory Translation Table Michal Wajdeczko
2023-12-07 0:43 ` Michał Winiarski
2023-12-07 14:55 ` Michal Wajdeczko
2023-11-28 15:15 ` [Intel-xe] [PATCH 4/5] drm/xe/kunit: Enable CONFIG_PCI_IOV in .kunitconfig Michal Wajdeczko
2023-12-07 0:24 ` Michał Winiarski
2023-11-28 15:15 ` Michal Wajdeczko [this message]
2023-12-07 0:23 ` [Intel-xe] [PATCH 5/5] drm/xe/kunit: Add test for LMTT operations Michał Winiarski
2023-11-28 16:30 ` [Intel-xe] ✓ CI.Patch_applied: success for Introduce Local Memory Translation Table Patchwork
2023-11-28 16:30 ` [Intel-xe] ✗ CI.checkpatch: warning " Patchwork
2023-11-28 16:31 ` [Intel-xe] ✓ CI.KUnit: success " Patchwork
2023-11-28 16:39 ` [Intel-xe] ✓ CI.Build: " Patchwork
2023-11-28 16:39 ` [Intel-xe] ✗ CI.Hooks: failure " Patchwork
2023-11-28 16:41 ` [Intel-xe] ✓ CI.checksparse: success " Patchwork
2023-11-28 17:14 ` [Intel-xe] ✓ CI.BAT: " Patchwork
2023-12-11 21:21 ` [Intel-xe] [PATCH 0/5] " Rodrigo Vivi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231128151507.1015-6-michal.wajdeczko@intel.com \
--to=michal.wajdeczko@intel.com \
--cc=intel-xe@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox