From: Sujaritha Sundaresan <sujaritha.sundaresan@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: Sujaritha Sundaresan <sujaritha.sundaresan@intel.com>,
rodrigo.vivi@intel.com
Subject: [Intel-xe] [v2 1/2] drm/xe: Add a new memory directory under tile
Date: Wed, 6 Dec 2023 10:17:34 +0530 [thread overview]
Message-ID: <20231206044735.966213-2-sujaritha.sundaresan@intel.com> (raw)
In-Reply-To: <20231206044735.966213-1-sujaritha.sundaresan@intel.com>
Add a new memory directory under /device/tile<n> and move
physical_vram_size attribute to the new directory.
New hierarchy:
/device/tile<n>/memory/physical_vram_size_bytes
v2: Fix heading typo (Riana)
Fix cleanup error on unload/reload cycle
Signed-off-by: Sujaritha Sundaresan <sujaritha.sundaresan@intel.com>
---
drivers/gpu/drm/xe/xe_tile_sysfs.c | 15 ++++++++++++---
1 file changed, 12 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/xe/xe_tile_sysfs.c b/drivers/gpu/drm/xe/xe_tile_sysfs.c
index 16376607c68f..e8ce4d9270e6 100644
--- a/drivers/gpu/drm/xe/xe_tile_sysfs.c
+++ b/drivers/gpu/drm/xe/xe_tile_sysfs.c
@@ -24,7 +24,8 @@ static ssize_t
physical_vram_size_bytes_show(struct device *kdev, struct device_attribute *attr,
char *buf)
{
- struct xe_tile *tile = kobj_to_tile(&kdev->kobj);
+ struct kobject *kobj = &kdev->kobj;
+ struct xe_tile *tile = kobj_to_tile(kobj->parent);
return sysfs_emit(buf, "%llu\n", tile->mem.vram.actual_physical_size);
}
@@ -38,7 +39,7 @@ static void tile_sysfs_fini(struct drm_device *drm, void *arg)
{
struct xe_tile *tile = arg;
- kobject_put(tile->sysfs);
+ kobject_del(tile->sysfs);
}
void xe_tile_sysfs_init(struct xe_tile *tile)
@@ -46,6 +47,7 @@ void xe_tile_sysfs_init(struct xe_tile *tile)
struct xe_device *xe = tile_to_xe(tile);
struct device *dev = xe->drm.dev;
struct kobj_tile *kt;
+ struct kobject *kobj;
int err;
kt = kzalloc(sizeof(*kt), GFP_KERNEL);
@@ -64,8 +66,15 @@ void xe_tile_sysfs_init(struct xe_tile *tile)
tile->sysfs = &kt->base;
+ kobj = kobject_create_and_add("memory", tile->sysfs);
+ if (!kobj) {
+ kobject_put(kobj);
+ drm_warn(&xe->drm, "%s failed, err: %d\n", __func__, -ENOMEM);
+ return;
+ }
+
if (IS_DGFX(xe) && xe->info.platform != XE_DG1 &&
- sysfs_create_file(tile->sysfs, physical_memsize_attr))
+ sysfs_create_file(kobj, physical_memsize_attr))
drm_warn(&xe->drm,
"Sysfs creation to read addr_range per tile failed\n");
--
2.25.1
next prev parent reply other threads:[~2023-12-06 4:33 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-06 4:47 [Intel-xe] [v2 0/2] Add memory sysfs directory and attributes Sujaritha Sundaresan
2023-12-06 4:47 ` Sujaritha Sundaresan [this message]
2023-12-06 11:53 ` [Intel-xe] [v2 1/2] drm/xe: Add a new memory directory under tile Gupta, Anshuman
2023-12-06 12:08 ` Sundaresan, Sujaritha
2023-12-06 12:13 ` Sundaresan, Sujaritha
2023-12-07 5:12 ` Upadhyay, Tejas
2023-12-07 5:21 ` Sundaresan, Sujaritha
2023-12-07 6:06 ` Riana Tauro
2023-12-07 6:38 ` Sundaresan, Sujaritha
2023-12-07 7:28 ` Sundaresan, Sujaritha
2023-12-07 8:30 ` Upadhyay, Tejas
2023-12-07 9:55 ` Sundaresan, Sujaritha
2023-12-07 12:38 ` Upadhyay, Tejas
2023-12-07 13:04 ` Sundaresan, Sujaritha
2023-12-06 4:47 ` [Intel-xe] [v2 2/2] drm/xe: Add vram frequency sysfs attributes Sujaritha Sundaresan
2023-12-06 11:55 ` Gupta, Anshuman
2023-12-06 12:10 ` Sundaresan, Sujaritha
2023-12-07 5:36 ` Sundaresan, Sujaritha
2023-12-07 6:02 ` Riana Tauro
2023-12-07 6:45 ` Sundaresan, Sujaritha
2023-12-06 9:46 ` [Intel-xe] ✓ CI.Patch_applied: success for Add memory sysfs directory and attributes (rev2) Patchwork
2023-12-06 9:46 ` [Intel-xe] ✗ CI.checkpatch: warning " Patchwork
2023-12-06 9:47 ` [Intel-xe] ✓ CI.KUnit: success " Patchwork
2023-12-06 9:55 ` [Intel-xe] ✓ CI.Build: " Patchwork
2023-12-06 9:55 ` [Intel-xe] ✓ CI.Hooks: " Patchwork
2023-12-06 9:56 ` [Intel-xe] ✓ CI.checksparse: " Patchwork
2023-12-06 10:35 ` [Intel-xe] ✓ CI.BAT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231206044735.966213-2-sujaritha.sundaresan@intel.com \
--to=sujaritha.sundaresan@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox