Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Jouni Högander" <jouni.hogander@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: "Jouni Högander" <jouni.hogander@intel.com>
Subject: [PATCH v2 6/9] fixup! FIXME: drm/i915/display: Remaining changes to make xe compile
Date: Thu,  7 Dec 2023 15:00:43 +0200	[thread overview]
Message-ID: <20231207130046.2350822-7-jouni.hogander@intel.com> (raw)
In-Reply-To: <20231207130046.2350822-1-jouni.hogander@intel.com>

We have now everything to build intel_display.c as it is without any
ifdefs. Thus revert local changes from intel_display.c.

Signed-off-by: Jouni Högander <jouni.hogander@intel.com>
---
 drivers/gpu/drm/i915/display/intel_display.c | 35 --------------------
 1 file changed, 35 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
index 5069b31bf1b7..c3a3a4c3b363 100644
--- a/drivers/gpu/drm/i915/display/intel_display.c
+++ b/drivers/gpu/drm/i915/display/intel_display.c
@@ -42,10 +42,8 @@
 #include <drm/drm_probe_helper.h>
 #include <drm/drm_rect.h>
 
-#ifdef I915
 #include "gem/i915_gem_lmem.h"
 #include "gem/i915_gem_object.h"
-#endif
 
 #include "g4x_dp.h"
 #include "g4x_hdmi.h"
@@ -7095,39 +7093,6 @@ static void intel_atomic_cleanup_work(struct work_struct *work)
 	intel_atomic_helper_free_state(i915);
 }
 
-#ifndef I915
-static int i915_gem_object_read_from_page(struct xe_bo *bo,
-					  u32 ofs, u64 *ptr, u32 size)
-{
-	struct ttm_bo_kmap_obj map;
-	void *virtual;
-	bool is_iomem;
-	int ret;
-
-	XE_WARN_ON(size != 8);
-
-	ret = xe_bo_lock(bo, true);
-	if (ret)
-		return ret;
-
-	ret = ttm_bo_kmap(&bo->ttm, ofs >> PAGE_SHIFT, 1, &map);
-	if (ret)
-		goto out_unlock;
-
-	ofs &= ~PAGE_MASK;
-	virtual = ttm_kmap_obj_virtual(&map, &is_iomem);
-	if (is_iomem)
-		*ptr = readq((void __iomem *)(virtual + ofs));
-	else
-		*ptr = *(u64 *)(virtual + ofs);
-
-	ttm_bo_kunmap(&map);
-out_unlock:
-	xe_bo_unlock(bo);
-	return ret;
-}
-#endif
-
 static void intel_atomic_prepare_plane_clear_colors(struct intel_atomic_state *state)
 {
 	struct drm_i915_private *i915 = to_i915(state->base.dev);
-- 
2.34.1


  parent reply	other threads:[~2023-12-07 13:01 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-07 13:00 [PATCH v2 0/9] Handle remaining ifdefs in hack patch Jouni Högander
2023-12-07 13:00 ` [PATCH v2 1/9] fixup! FIXME: drm/i915/display: Remaining changes to make xe compile Jouni Högander
2023-12-07 13:00 ` [PATCH v2 2/9] drm/i915/display: Use i915_gem_object_get_dma_address to get dma address Jouni Högander
2023-12-07 13:00 ` [PATCH v2 3/9] fixup! drm/xe/display: Implement display support Jouni Högander
2023-12-07 13:00 ` [PATCH v2 4/9] " Jouni Högander
2023-12-07 13:00 ` [PATCH v2 5/9] " Jouni Högander
2023-12-07 13:00 ` Jouni Högander [this message]
2023-12-07 13:00 ` [PATCH v2 7/9] fixup! FIXME: drm/i915/display: Remaining changes to make xe compile Jouni Högander
2023-12-07 13:00 ` [PATCH v2 8/9] fixup! drm/xe/display: Implement display support Jouni Högander
2023-12-07 13:00 ` [PATCH v2 9/9] fixup! FIXME: drm/i915/display: Remaining changes to make xe compile Jouni Högander
2023-12-07 15:06   ` Maarten Lankhorst
2023-12-07 14:17 ` ✓ CI.Patch_applied: success for Handle remaining ifdefs in hack patch (rev2) Patchwork
2023-12-07 14:17 ` ✗ CI.checkpatch: warning " Patchwork
2023-12-07 14:18 ` ✓ CI.KUnit: success " Patchwork
2023-12-07 14:25 ` ✓ CI.Build: " Patchwork
2023-12-07 14:26 ` ✓ CI.Hooks: " Patchwork
2023-12-07 14:27 ` ✗ CI.checksparse: warning " Patchwork
2023-12-07 15:02 ` ✓ CI.BAT: success " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231207130046.2350822-7-jouni.hogander@intel.com \
    --to=jouni.hogander@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox