From: "Thomas Hellström" <thomas.hellstrom@linux.intel.com>
To: intel-xe@lists.freedesktop.org
Subject: [PATCH 15/16] drm/xe: Adjust to commit "drm/gpuvm: add an abstraction for a VM/BO combination"
Date: Thu, 7 Dec 2023 15:11:55 +0100 [thread overview]
Message-ID: <20231207141157.26014-16-thomas.hellstrom@linux.intel.com> (raw)
In-Reply-To: <20231207141157.26014-1-thomas.hellstrom@linux.intel.com>
Signed-off-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
---
drivers/gpu/drm/xe/xe_bo.c | 11 +++++++----
drivers/gpu/drm/xe/xe_vm.c | 33 ++++++++++++++++++++++++++-------
2 files changed, 33 insertions(+), 11 deletions(-)
diff --git a/drivers/gpu/drm/xe/xe_bo.c b/drivers/gpu/drm/xe/xe_bo.c
index ad9d8793db3e..7e25c8b7a01a 100644
--- a/drivers/gpu/drm/xe/xe_bo.c
+++ b/drivers/gpu/drm/xe/xe_bo.c
@@ -470,6 +470,7 @@ static int xe_bo_trigger_rebind(struct xe_device *xe, struct xe_bo *bo,
struct dma_fence *fence;
struct drm_gpuva *gpuva;
struct drm_gem_object *obj = &bo->ttm.base;
+ struct drm_gpuvm_bo *vm_bo;
int ret = 0;
dma_resv_assert_held(bo->ttm.base.resv);
@@ -482,11 +483,12 @@ static int xe_bo_trigger_rebind(struct xe_device *xe, struct xe_bo *bo,
dma_resv_iter_end(&cursor);
}
- drm_gem_for_each_gpuva(gpuva, obj) {
- struct xe_vma *vma = gpuva_to_vma(gpuva);
- struct xe_vm *vm = xe_vma_vm(vma);
+ drm_gem_for_each_gpuvm_bo(vm_bo, obj) {
+ drm_gpuvm_bo_for_each_va(gpuva, vm_bo) {
+ struct xe_vma *vma = gpuva_to_vma(gpuva);
+ struct xe_vm *vm = xe_vma_vm(vma);
- trace_xe_vma_evict(vma);
+ trace_xe_vma_evict(vma);
if (xe_vm_in_fault_mode(vm)) {
/* Wait for pending binds / unbinds. */
@@ -540,6 +542,7 @@ static int xe_bo_trigger_rebind(struct xe_device *xe, struct xe_bo *bo,
if (vm_resv_locked)
dma_resv_unlock(xe_vm_resv(vm));
}
+ }
}
return ret;
diff --git a/drivers/gpu/drm/xe/xe_vm.c b/drivers/gpu/drm/xe/xe_vm.c
index 6c8a84026af4..f71285e8ef10 100644
--- a/drivers/gpu/drm/xe/xe_vm.c
+++ b/drivers/gpu/drm/xe/xe_vm.c
@@ -911,12 +911,21 @@ static struct xe_vma *xe_vma_create(struct xe_vm *vm,
vma->pat_index = pat_index;
if (bo) {
+ struct drm_gpuvm_bo *vm_bo;
+
xe_bo_assert_held(bo);
+ vm_bo = drm_gpuvm_bo_obtain(vma->gpuva.vm, &bo->ttm.base);
+ if (IS_ERR(vm_bo)) {
+ kfree(vma);
+ return ERR_CAST(vm_bo);
+ }
+
drm_gem_object_get(&bo->ttm.base);
vma->gpuva.gem.obj = &bo->ttm.base;
vma->gpuva.gem.offset = bo_offset_or_userptr;
- drm_gpuva_link(&vma->gpuva);
+ drm_gpuva_link(&vma->gpuva, vm_bo);
+ drm_gpuvm_bo_put(vm_bo);
} else /* userptr or null */ {
if (!is_null) {
u64 size = end - start + 1;
@@ -998,16 +1007,19 @@ static struct xe_vma *
bo_has_vm_references_locked(struct xe_bo *bo, struct xe_vm *vm,
struct xe_vma *ignore)
{
- struct drm_gpuva *gpuva;
+ struct drm_gpuvm_bo *vm_bo;
+ struct drm_gpuva *va;
struct drm_gem_object *obj = &bo->ttm.base;
xe_bo_assert_held(bo);
- drm_gem_for_each_gpuva(gpuva, obj) {
- struct xe_vma *vma = gpuva_to_vma(gpuva);
+ drm_gem_for_each_gpuvm_bo(vm_bo, obj) {
+ drm_gpuvm_bo_for_each_va(va, vm_bo) {
+ struct xe_vma *vma = gpuva_to_vma(va);
- if (vma != ignore && xe_vma_vm(vma) == vm)
- return vma;
+ if (vma != ignore && xe_vma_vm(vma) == vm)
+ return vma;
+ }
}
return NULL;
@@ -2156,6 +2168,7 @@ vm_bind_ioctl_ops_create(struct xe_vm *vm, struct xe_bo *bo,
struct drm_gpuva_ops *ops;
struct drm_gpuva_op *__op;
struct xe_vma_op *op;
+ struct drm_gpuvm_bo *vm_bo;
int err;
lockdep_assert_held_write(&vm->lock);
@@ -2183,7 +2196,13 @@ vm_bind_ioctl_ops_create(struct xe_vm *vm, struct xe_bo *bo,
err = xe_bo_lock(bo, true);
if (err)
return ERR_PTR(err);
- ops = drm_gpuvm_gem_unmap_ops_create(&vm->gpuvm, obj);
+
+ vm_bo = drm_gpuvm_bo_find(&vm->gpuvm, obj);
+ if (!vm_bo)
+ break;
+
+ ops = drm_gpuvm_bo_unmap_ops_create(vm_bo);
+ drm_gpuvm_bo_put(vm_bo);
xe_bo_unlock(bo);
break;
default:
--
2.42.0
next prev parent reply other threads:[~2023-12-07 14:12 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-07 14:11 [PATCH 00/16] drm/xe: Adjust to DRM GPUVM changes Thomas Hellström
2023-12-07 14:11 ` [PATCH 01/16] drm/gpuvm: convert WARN() to drm_WARN() variants Thomas Hellström
2023-12-07 14:11 ` [PATCH 02/16] drm/gpuvm: don't always WARN in drm_gpuvm_check_overflow() Thomas Hellström
2023-12-07 14:11 ` [PATCH 03/16] drm/gpuvm: export drm_gpuvm_range_valid() Thomas Hellström
2023-12-07 14:11 ` [PATCH 04/16] drm/nouveau: make use of drm_gpuvm_range_valid() Thomas Hellström
2023-12-07 14:11 ` [PATCH 05/16] drm/gpuvm: add common dma-resv per struct drm_gpuvm Thomas Hellström
2023-12-07 14:11 ` [PATCH 06/16] drm/nouveau: make use of the GPUVM's shared dma-resv Thomas Hellström
2023-12-07 14:11 ` [PATCH 07/16] drm/gpuvm: add drm_gpuvm_flags to drm_gpuvm Thomas Hellström
2023-12-07 14:11 ` [PATCH 08/16] drm/nouveau: separately allocate struct nouveau_uvmm Thomas Hellström
2023-12-07 14:11 ` [PATCH 09/16] drm/gpuvm: reference count drm_gpuvm structures Thomas Hellström
2023-12-07 14:11 ` [PATCH 10/16] drm/gpuvm: add an abstraction for a VM / BO combination Thomas Hellström
2023-12-07 14:11 ` [PATCH 11/16] drm/gpuvm: track/lock/validate external/evicted objects Thomas Hellström
2023-12-07 14:11 ` [PATCH 12/16] drm/xe: Adjust to "drm/gpuvm: add common dma-resv per struct drm_gpuvm" Thomas Hellström
2023-12-07 19:08 ` Rodrigo Vivi
2023-12-07 14:11 ` [PATCH 13/16] drm/xe: Adjust to commit "drm/gpuvm: add drm_gpuvm_flags to drm_gpuvm" Thomas Hellström
2023-12-07 19:04 ` Rodrigo Vivi
2023-12-07 14:11 ` [PATCH 14/16] drm/xe: Adjust to commit drm/gpuvm: reference count drm_gpuvm structures Thomas Hellström
2023-12-07 14:11 ` Thomas Hellström [this message]
2023-12-07 12:38 ` [PATCH 15/16] drm/xe: Adjust to commit "drm/gpuvm: add an abstraction for a VM/BO combination" Matthew Brost
2023-12-07 20:36 ` Rodrigo Vivi
2023-12-07 19:09 ` Rodrigo Vivi
2023-12-07 14:11 ` [PATCH 16/16] drm/xe: Use DRM_GPUVM_RESV_PROTECTED for gpuvm Thomas Hellström
2023-12-07 19:44 ` ✓ CI.Patch_applied: success for drm/xe: Adjust to DRM GPUVM changes Patchwork
2023-12-07 19:45 ` ✗ CI.checkpatch: warning " Patchwork
2023-12-07 19:46 ` ✓ CI.KUnit: success " Patchwork
2023-12-07 19:54 ` ✓ CI.Build: " Patchwork
2023-12-07 19:54 ` ✓ CI.Hooks: " Patchwork
2023-12-07 19:55 ` ✗ CI.checksparse: warning " Patchwork
2023-12-07 20:32 ` ✓ CI.BAT: success " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231207141157.26014-16-thomas.hellstrom@linux.intel.com \
--to=thomas.hellstrom@linux.intel.com \
--cc=intel-xe@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox