Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Matt Roper <matthew.d.roper@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: Francois Dugast <francois.dugast@intel.com>,
	matthew.d.roper@intel.com, Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: [PATCH v2 0/2] xe: Add IP versions to GT query
Date: Thu,  7 Dec 2023 16:22:19 -0800	[thread overview]
Message-ID: <20231208002218.1287673-4-matthew.d.roper@intel.com> (raw)

On MTL and later, drivers are expected to determine graphics/media
version and stepping from the values reported in the GMD_ID registers
rather than trying to infer them from PCI devid/revid.  Since userspace
cannot directly access these registers, the graphics/media GMD_ID must
be exposed through the uapi.

Repurpose one of the 'reserved' qwords in the GT query structure to hold
the IP version for platforms with GMD_ID.  These fields will continue to
be 0 on pre-MTL platforms.  Userspace should continue to utilize PCI
devid/revid on those older platforms.

Note that although the hardware has a display IP GMD_ID register as
well, that value will not be exposed through Xe uapi.  As always,
display userspace is expected to use standard atomic properties and
test-only commits to determine platform capabilities rather than
attempting to recognize the underlying IP.

v2:
 - Tweak field naming from "revid" to "rev"  (Lucas)
 - Fix kerneldoc copy/paste mistakes.

Test-with: 20231206204942.1105505-1-matthew.d.roper@intel.com
Testcase: igt@xe_query@query-gt-list
Cc: Francois Dugast <francois.dugast@intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>

Matt Roper (2):
  drm/xe: Stash GMD_ID value in xe_gt
  drm/xe/uapi: Add IP version and stepping to GT list query

 drivers/gpu/drm/xe/xe_gt.c       |  6 ++++++
 drivers/gpu/drm/xe/xe_gt_types.h |  2 ++
 drivers/gpu/drm/xe/xe_query.c    |  8 ++++++++
 include/uapi/drm/xe_drm.h        | 10 +++++++++-
 4 files changed, 25 insertions(+), 1 deletion(-)

-- 
2.43.0


             reply	other threads:[~2023-12-08  0:22 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-08  0:22 Matt Roper [this message]
2023-12-08  0:22 ` [PATCH v2 1/2] drm/xe: Stash GMD_ID value in xe_gt Matt Roper
2023-12-08  0:22 ` [PATCH v2 2/2] drm/xe/uapi: Add IP version and stepping to GT list query Matt Roper
2023-12-08  4:11 ` ✓ CI.Patch_applied: success for xe: Add IP versions to GT query (rev2) Patchwork
2023-12-08  4:12 ` ✓ CI.checkpatch: " Patchwork
2023-12-08  4:13 ` ✓ CI.KUnit: " Patchwork
2023-12-08  4:20 ` ✓ CI.Build: " Patchwork
2023-12-08  4:21 ` ✓ CI.Hooks: " Patchwork
2023-12-08  4:22 ` ✓ CI.checksparse: " Patchwork
2023-12-08  4:59 ` ✓ CI.BAT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231208002218.1287673-4-matthew.d.roper@intel.com \
    --to=matthew.d.roper@intel.com \
    --cc=francois.dugast@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=rodrigo.vivi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox