From: Francois Dugast <francois.dugast@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: Francois Dugast <francois.dugast@intel.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: [PATCH] drm/xe/uapi: Remove DRM_XE_UFENCE_WAIT_MASK_*
Date: Sat, 9 Dec 2023 07:45:58 +0000 [thread overview]
Message-ID: <20231209074558.7-1-francois.dugast@intel.com> (raw)
Those are just possible values for the comparison mask but they are not
specific magic values. Let's keep them as examples in the documentation
but remove them from the uAPI.
Suggested-by: Matthew Brost <matthew.brost@intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: Francois Dugast <francois.dugast@intel.com>
---
include/uapi/drm/xe_drm.h | 12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/include/uapi/drm/xe_drm.h b/include/uapi/drm/xe_drm.h
index 0895e4d2a981..a0e8bf4cadc8 100644
--- a/include/uapi/drm/xe_drm.h
+++ b/include/uapi/drm/xe_drm.h
@@ -1042,11 +1042,13 @@ struct drm_xe_wait_user_fence {
/** @value: compare value */
__u64 value;
-#define DRM_XE_UFENCE_WAIT_MASK_U8 0xffu
-#define DRM_XE_UFENCE_WAIT_MASK_U16 0xffffu
-#define DRM_XE_UFENCE_WAIT_MASK_U32 0xffffffffu
-#define DRM_XE_UFENCE_WAIT_MASK_U64 0xffffffffffffffffu
- /** @mask: comparison mask */
+ /**
+ * @mask: comparison mask, values can be for example:
+ * - 0xffu for u8
+ * - 0xffffu for u16
+ * - 0xffffffffu for u32
+ * - 0xffffffffffffffffu for u64
+ */
__u64 mask;
/**
--
2.34.1
next reply other threads:[~2023-12-09 7:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-09 7:45 Francois Dugast [this message]
2023-12-09 7:49 ` ✓ CI.Patch_applied: success for drm/xe/uapi: Remove DRM_XE_UFENCE_WAIT_MASK_* Patchwork
2023-12-09 7:49 ` ✓ CI.checkpatch: " Patchwork
2023-12-09 7:50 ` ✓ CI.KUnit: " Patchwork
2023-12-09 7:57 ` ✓ CI.Build: " Patchwork
2023-12-09 7:58 ` ✓ CI.Hooks: " Patchwork
2023-12-09 7:59 ` ✓ CI.checksparse: " Patchwork
2023-12-09 8:35 ` ✓ CI.BAT: " Patchwork
2023-12-11 8:26 ` [PATCH] " Matthew Brost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231209074558.7-1-francois.dugast@intel.com \
--to=francois.dugast@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox