From: Matthew Auld <matthew.auld@intel.com>
To: intel-xe@lists.freedesktop.org
Subject: [PATCH 2/2] drm/xe/exec: reserve fence slot for CPU bind
Date: Wed, 13 Dec 2023 17:47:05 +0000 [thread overview]
Message-ID: <20231213174703.536989-4-matthew.auld@intel.com> (raw)
In-Reply-To: <20231213174703.536989-3-matthew.auld@intel.com>
Looks possible to switch from CPU binding to GPU binding mid exec, and
if that happens for the same dma-resv we might use two fence slots, once
for the dummy fence, and another for the actual GPU bind.
References: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/698
Signed-off-by: Matthew Auld <matthew.auld@intel.com>
Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com>
Cc: Matthew Brost <matthew.brost@intel.com>
---
drivers/gpu/drm/xe/xe_exec.c | 12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/xe/xe_exec.c b/drivers/gpu/drm/xe/xe_exec.c
index 63e82e5285bc..0c78a377f453 100644
--- a/drivers/gpu/drm/xe/xe_exec.c
+++ b/drivers/gpu/drm/xe/xe_exec.c
@@ -107,12 +107,14 @@ static int xe_exec_fn(struct drm_gpuvm_exec *vm_exec)
return ret;
/*
- * 1 fence slot for the final submit, and one more for every per-tile
- * bind. Note that there are potentially many vma per object/dma-resv,
- * however the fence slot will just be re-used, since they are largely
- * the same timeline and the seqno should be in order.
+ * 1 fence slot for the final submit, and 1 more for every per-tile for
+ * GPU bind and 1 extra for CPU bind. Note that there are potentially
+ * many vma per object/dma-resv, however the fence slot will just be
+ * re-used, since they are largely the same timeline and the seqno
+ * should be in order. In the case of CPU bind there is dummy fence used
+ * for all CPU binds, so no need to have a per-tile slot for that.
*/
- num_fences = 1 + vm->xe->info.tile_count;
+ num_fences = 1 + 1 + vm->xe->info.tile_count;
/*
* We don't know upfront exactly how many fence slots we will need at
--
2.43.0
next prev parent reply other threads:[~2023-12-13 17:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-13 17:47 [PATCH 1/2] drm/xe/exec: move fence reservation Matthew Auld
2023-12-13 17:47 ` Matthew Auld [this message]
2023-12-21 13:46 ` [PATCH 2/2] drm/xe/exec: reserve fence slot for CPU bind Souza, Jose
2023-12-13 17:51 ` ✓ CI.Patch_applied: success for series starting with [1/2] drm/xe/exec: move fence reservation Patchwork
2023-12-13 17:51 ` ✗ CI.checkpatch: warning " Patchwork
2023-12-13 17:52 ` ✓ CI.KUnit: success " Patchwork
2023-12-13 17:59 ` ✓ CI.Build: " Patchwork
2023-12-13 18:00 ` ✓ CI.Hooks: " Patchwork
2023-12-13 18:01 ` ✓ CI.checksparse: " Patchwork
2023-12-13 18:41 ` ✓ CI.BAT: " Patchwork
2023-12-14 16:19 ` [PATCH 1/2] " Souza, Jose
2023-12-21 13:46 ` Souza, Jose
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231213174703.536989-4-matthew.auld@intel.com \
--to=matthew.auld@intel.com \
--cc=intel-xe@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox