From: Michal Wajdeczko <michal.wajdeczko@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: Matt Roper <matthew.d.roper@intel.com>
Subject: [PATCH v4 02/10] drm/xe: Report TLB timeout using GT oriented functions
Date: Fri, 15 Dec 2023 17:24:54 +0100 [thread overview]
Message-ID: <20231215162502.1879-3-michal.wajdeczko@intel.com> (raw)
In-Reply-To: <20231215162502.1879-1-michal.wajdeczko@intel.com>
We track TLB invalidation seqno per GT and we have GT oriented
message helpers, so it's better to use GT oriented log functions.
Cc: Matt Roper <matthew.d.roper@intel.com>
Cc: Matthew Brost <matthew.brost@intel.com>
Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
---
drivers/gpu/drm/xe/xe_gt_tlb_invalidation.c | 13 +++++++------
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/xe/xe_gt_tlb_invalidation.c b/drivers/gpu/drm/xe/xe_gt_tlb_invalidation.c
index 7eef23a00d77..e3a4131ebb58 100644
--- a/drivers/gpu/drm/xe/xe_gt_tlb_invalidation.c
+++ b/drivers/gpu/drm/xe/xe_gt_tlb_invalidation.c
@@ -8,6 +8,7 @@
#include "abi/guc_actions_abi.h"
#include "xe_device.h"
#include "xe_gt.h"
+#include "xe_gt_printk.h"
#include "xe_guc.h"
#include "xe_guc_ct.h"
#include "xe_trace.h"
@@ -30,8 +31,8 @@ static void xe_gt_tlb_fence_timeout(struct work_struct *work)
break;
trace_xe_gt_tlb_invalidation_fence_timeout(fence);
- drm_err(>_to_xe(gt)->drm, "gt%d: TLB invalidation fence timeout, seqno=%d recv=%d",
- gt->info.id, fence->seqno, gt->tlb_invalidation.seqno_recv);
+ xe_gt_err(gt, "TLB invalidation fence timeout, seqno=%d recv=%d",
+ fence->seqno, gt->tlb_invalidation.seqno_recv);
list_del(&fence->link);
fence->base.error = -ETIME;
@@ -312,9 +313,7 @@ int xe_gt_tlb_invalidation_vma(struct xe_gt *gt,
*/
int xe_gt_tlb_invalidation_wait(struct xe_gt *gt, int seqno)
{
- struct xe_device *xe = gt_to_xe(gt);
struct xe_guc *guc = >->uc.guc;
- struct drm_printer p = drm_err_printer(__func__);
int ret;
/*
@@ -325,8 +324,10 @@ int xe_gt_tlb_invalidation_wait(struct xe_gt *gt, int seqno)
tlb_invalidation_seqno_past(gt, seqno),
TLB_TIMEOUT);
if (!ret) {
- drm_err(&xe->drm, "gt%d: TLB invalidation time'd out, seqno=%d, recv=%d\n",
- gt->info.id, seqno, gt->tlb_invalidation.seqno_recv);
+ struct drm_printer p = xe_gt_err_printer(gt);
+
+ xe_gt_err(gt, "TLB invalidation time'd out, seqno=%d, recv=%d\n",
+ seqno, gt->tlb_invalidation.seqno_recv);
xe_guc_ct_print(&guc->ct, &p, true);
return -ETIME;
}
--
2.25.1
next prev parent reply other threads:[~2023-12-15 16:25 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-15 16:24 [PATCH v4 00/10] Introduce GuC Doorbells Manager Michal Wajdeczko
2023-12-15 16:24 ` [PATCH v4 01/10] drm/xe: Add GT oriented drm_printers Michal Wajdeczko
2023-12-15 21:48 ` Lucas De Marchi
2023-12-15 16:24 ` Michal Wajdeczko [this message]
2023-12-15 21:50 ` [PATCH v4 02/10] drm/xe: Report TLB timeout using GT oriented functions Lucas De Marchi
2023-12-15 16:24 ` [PATCH v4 03/10] drm/xe: Introduce GuC Doorbells Manager Michal Wajdeczko
2023-12-15 16:24 ` [PATCH v4 04/10] drm/xe/kunit: Set SR-IOV mode of the fake device Michal Wajdeczko
2023-12-15 16:24 ` [PATCH v4 05/10] drm/xe/kunit: Define helper functions to allocate fake xe device Michal Wajdeczko
2023-12-15 22:01 ` Lucas De Marchi
2023-12-15 16:24 ` [PATCH v4 06/10] drm/xe/kunit: Restore test->priv when done with " Michal Wajdeczko
2023-12-15 22:11 ` Lucas De Marchi
2023-12-16 12:11 ` Michal Wajdeczko
2023-12-15 16:24 ` [PATCH v4 07/10] drm/xe/kunit: Use xe kunit helper in RTP test Michal Wajdeczko
2023-12-15 22:05 ` Lucas De Marchi
2023-12-15 16:25 ` [PATCH v4 08/10] drm/xe/kunit: Use xe kunit helper in WA test Michal Wajdeczko
2023-12-15 22:06 ` Lucas De Marchi
2023-12-15 16:25 ` [PATCH v4 09/10] drm/xe/kunit: Enable CONFIG_LOCKDEP in tests Michal Wajdeczko
2023-12-15 22:06 ` Lucas De Marchi
2023-12-15 16:25 ` [PATCH v4 10/10] drm/xe/kunit: Add GuC Doorbells Manager tests Michal Wajdeczko
2023-12-15 17:53 ` ✓ CI.Patch_applied: success for Introduce GuC Doorbells Manager (rev4) Patchwork
2023-12-15 17:53 ` ✗ CI.checkpatch: warning " Patchwork
2023-12-15 17:55 ` ✓ CI.KUnit: success " Patchwork
2023-12-15 18:02 ` ✓ CI.Build: " Patchwork
2023-12-15 18:02 ` ✓ CI.Hooks: " Patchwork
2023-12-15 18:04 ` ✓ CI.checksparse: " Patchwork
2023-12-15 18:36 ` ✓ CI.BAT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231215162502.1879-3-michal.wajdeczko@intel.com \
--to=michal.wajdeczko@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=matthew.d.roper@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox