From: Matthew Brost <matthew.brost@intel.com>
To: <intel-xe@lists.freedesktop.org>
Subject: [PATCH 4/4] drm/xe/guc: Flush G2H handler when turning off CTs
Date: Thu, 28 Dec 2023 20:35:07 -0800 [thread overview]
Message-ID: <20231229043507.1002411-5-matthew.brost@intel.com> (raw)
In-Reply-To: <20231229043507.1002411-1-matthew.brost@intel.com>
Make sure G2H handler is not running when changing the CT state to drop
messages or disabled. This will help prevent races in the code ensuring
that G2H are not being processed after changing the state.
Signed-off-by: Matthew Brost <matthew.brost@intel.com>
---
drivers/gpu/drm/xe/xe_guc_ct.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/gpu/drm/xe/xe_guc_ct.c b/drivers/gpu/drm/xe/xe_guc_ct.c
index 8c91d189d859..24331d20ddf8 100644
--- a/drivers/gpu/drm/xe/xe_guc_ct.c
+++ b/drivers/gpu/drm/xe/xe_guc_ct.c
@@ -328,14 +328,21 @@ int xe_guc_ct_enable(struct xe_guc_ct *ct)
return err;
}
+static void flush_g2h_handler(struct xe_guc_ct *ct)
+{
+ cancel_work_sync(&ct->g2h_worker);
+}
+
void xe_guc_ct_disable(struct xe_guc_ct *ct)
{
xe_guc_ct_set_state(ct, XE_GUC_CT_STATE_DISABLED);
+ flush_g2h_handler(ct);
}
void xe_guc_ct_drop_messages(struct xe_guc_ct *ct)
{
xe_guc_ct_set_state(ct, XE_GUC_CT_STATE_DROP_MESSAGES);
+ flush_g2h_handler(ct);
xa_destroy(&ct->fence_lookup);
}
--
2.34.1
next prev parent reply other threads:[~2023-12-29 4:36 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-29 4:35 [PATCH 0/4] GuC CT tweaks Matthew Brost
2023-12-29 4:35 ` [PATCH 1/4] drm/xe/guc: Add more GuC CT states Matthew Brost
2023-12-29 23:36 ` Michal Wajdeczko
2024-01-02 16:52 ` Matthew Brost
2023-12-29 4:35 ` [PATCH 2/4] drm/xe: Move TLB invalidation reset before HW reset Matthew Brost
2023-12-29 4:35 ` [PATCH 3/4] drm/xe/guc: Protect queuing of G2H handler with fast lock Matthew Brost
2023-12-29 4:35 ` Matthew Brost [this message]
2024-01-04 4:03 ` ✓ CI.Patch_applied: success for GuC CT tweaks Patchwork
2024-01-04 4:03 ` ✗ CI.checkpatch: warning " Patchwork
2024-01-04 4:04 ` ✓ CI.KUnit: success " Patchwork
2024-01-04 4:11 ` ✓ CI.Build: " Patchwork
2024-01-04 4:12 ` ✓ CI.Hooks: " Patchwork
2024-01-04 4:13 ` ✓ CI.checksparse: " Patchwork
2024-01-04 4:48 ` ✓ CI.BAT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231229043507.1002411-5-matthew.brost@intel.com \
--to=matthew.brost@intel.com \
--cc=intel-xe@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox