From: fei.yang@intel.com
To: intel-xe@lists.freedesktop.org
Subject: [PATCH v3 1/1] drm/xe: correct the calculation of remaining size
Date: Tue, 16 Jan 2024 14:37:09 -0800 [thread overview]
Message-ID: <20240116223709.652585-2-fei.yang@intel.com> (raw)
In-Reply-To: <20240116223709.652585-1-fei.yang@intel.com>
From: Fei Yang <fei.yang@intel.com>
In function write_pgtable, the calculation of chunk in the do-while
loop is wrong, we should always compare against remaining size instead
of the total size update->qwords.
Signed-off-by: Fei Yang <fei.yang@intel.com>
---
drivers/gpu/drm/xe/xe_migrate.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/xe/xe_migrate.c b/drivers/gpu/drm/xe/xe_migrate.c
index 44725f978f3e..d5392cbbdb49 100644
--- a/drivers/gpu/drm/xe/xe_migrate.c
+++ b/drivers/gpu/drm/xe/xe_migrate.c
@@ -1116,7 +1116,7 @@ static void write_pgtable(struct xe_tile *tile, struct xe_bb *bb, u64 ppgtt_ofs,
do {
u64 addr = ppgtt_ofs + ofs * 8;
- chunk = min(update->qwords, MAX_PTE_PER_SDI);
+ chunk = min(size, MAX_PTE_PER_SDI);
/* Ensure populatefn can do memset64 by aligning bb->cs */
if (!(bb->len & 1))
--
2.25.1
next prev parent reply other threads:[~2024-01-16 22:35 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-16 22:37 [PATCH v3 0/1] drm/xe: correct the calculation of remaining size fei.yang
2024-01-16 22:37 ` fei.yang [this message]
2024-01-16 22:41 ` [PATCH v3 1/1] " Matt Roper
2024-01-16 22:43 ` ✓ CI.Patch_applied: success for " Patchwork
2024-01-16 22:43 ` ✓ CI.checkpatch: " Patchwork
2024-01-16 22:44 ` ✓ CI.KUnit: " Patchwork
2024-01-16 22:51 ` ✓ CI.Build: " Patchwork
2024-01-16 22:52 ` ✓ CI.Hooks: " Patchwork
2024-01-16 22:53 ` ✓ CI.checksparse: " Patchwork
2024-01-17 17:39 ` ✓ CI.Patch_applied: " Patchwork
2024-01-17 17:40 ` ✓ CI.checkpatch: " Patchwork
2024-01-17 17:41 ` ✓ CI.KUnit: " Patchwork
2024-01-17 17:48 ` ✓ CI.Build: " Patchwork
2024-01-17 17:48 ` ✓ CI.Hooks: " Patchwork
2024-01-17 17:50 ` ✓ CI.checksparse: " Patchwork
2024-01-17 18:12 ` ✓ CI.BAT: " Patchwork
2024-01-18 22:52 ` Matt Roper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240116223709.652585-2-fei.yang@intel.com \
--to=fei.yang@intel.com \
--cc=intel-xe@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox