From: "José Roberto de Souza" <jose.souza@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: Maarten Lankhorst <dev@lankhorst.se>,
Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: [PATCH v2 3/9] drm/xe: Add functions to convert regular address to canonical address and back
Date: Mon, 22 Jan 2024 13:17:03 -0800 [thread overview]
Message-ID: <20240122211709.224419-3-jose.souza@intel.com> (raw)
In-Reply-To: <20240122211709.224419-1-jose.souza@intel.com>
Some instructions requires canonical address like
MI_BATCH_BUFFER_START(UMDs must call xe_exec with a canonical address
for Xe2+).
So here adding functions to convert regular address to canonical
address and back, the first user of this functions will be added
in the next patches.
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Maarten Lankhorst <dev@lankhorst.se>
Cc: Stuart Summers <stuart.summers@intel.com>
Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
---
drivers/gpu/drm/xe/xe_device.c | 15 +++++++++++++++
drivers/gpu/drm/xe/xe_device.h | 3 +++
2 files changed, 18 insertions(+)
diff --git a/drivers/gpu/drm/xe/xe_device.c b/drivers/gpu/drm/xe/xe_device.c
index ab417f4f7d2a7..b4cdcf1b2081a 100644
--- a/drivers/gpu/drm/xe/xe_device.c
+++ b/drivers/gpu/drm/xe/xe_device.c
@@ -727,3 +727,18 @@ void xe_device_mem_access_put(struct xe_device *xe)
xe_assert(xe, ref >= 0);
}
+
+static inline int highest_address_bit_get(struct xe_device *xe)
+{
+ return xe->info.dma_mask_size > 48 ? 57 : 47;
+}
+
+u64 xe_device_canonicalize_addr(struct xe_device *xe, u64 address)
+{
+ return sign_extend64(address, highest_address_bit_get(xe));
+}
+
+u64 xe_device_uncanonicalize_addr(struct xe_device *xe, u64 address)
+{
+ return address & GENMASK_ULL(highest_address_bit_get(xe), 0);
+}
diff --git a/drivers/gpu/drm/xe/xe_device.h b/drivers/gpu/drm/xe/xe_device.h
index af8ac2e9e2709..ce20f6fe6219a 100644
--- a/drivers/gpu/drm/xe/xe_device.h
+++ b/drivers/gpu/drm/xe/xe_device.h
@@ -175,4 +175,7 @@ static inline bool xe_device_has_memirq(struct xe_device *xe)
u32 xe_device_ccs_bytes(struct xe_device *xe, u64 size);
+u64 xe_device_canonicalize_addr(struct xe_device *xe, u64 address);
+u64 xe_device_uncanonicalize_addr(struct xe_device *xe, u64 address);
+
#endif
--
2.43.0
next prev parent reply other threads:[~2024-01-22 21:17 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-22 21:17 [PATCH v2 1/9] drm/xe: Remove double new lines in devcoredump José Roberto de Souza
2024-01-22 21:17 ` [PATCH v2 2/9] drm/xe: Change devcoredump functions parameters to xe_sched_job José Roberto de Souza
2024-01-22 21:17 ` José Roberto de Souza [this message]
2024-01-22 21:17 ` [PATCH v2 4/9] drm/xe: Add batch buffer addresses to devcoredump José Roberto de Souza
2024-01-22 21:17 ` [PATCH v2 5/9] drm/xe: Nuke xe from xe_devcoredump José Roberto de Souza
2024-01-22 21:17 ` [PATCH v2 6/9] drm/xe: Stash GMD_ID value in xe_gt José Roberto de Souza
2024-01-22 21:17 ` [PATCH v2 7/9] drm/xe: Print more device information in devcoredump José Roberto de Souza
2024-01-22 21:17 ` [PATCH v2 8/9] drm/xe: Print registers spread in 2 u32 as u64 José Roberto de Souza
2024-01-22 21:17 ` [PATCH v2 9/9] drm/xe: Remove additional spaces in devcoredump HW Engines section José Roberto de Souza
2024-01-22 21:40 ` ✓ CI.Patch_applied: success for series starting with [v2,1/9] drm/xe: Remove double new lines in devcoredump Patchwork
2024-01-22 21:40 ` ✓ CI.checkpatch: " Patchwork
2024-01-22 21:41 ` ✓ CI.KUnit: " Patchwork
2024-01-22 21:49 ` ✓ CI.Build: " Patchwork
2024-01-22 21:49 ` ✗ CI.Hooks: failure " Patchwork
2024-01-22 21:50 ` ✓ CI.checksparse: success " Patchwork
2024-01-22 22:14 ` ✓ CI.BAT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240122211709.224419-3-jose.souza@intel.com \
--to=jose.souza@intel.com \
--cc=dev@lankhorst.se \
--cc=intel-xe@lists.freedesktop.org \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox