From: Matthew Brost <matthew.brost@intel.com>
To: <intel-xe@lists.freedesktop.org>, dri-devel@lists.freedesktop.org
Cc: airlied@gmail.com, christian.koenig@amd.com, ltuikov89@gmail.com
Subject: [PATCH] drm/sched: Re-queue run job worker when drm_sched_entity_pop_job() returns NULL
Date: Mon, 29 Jan 2024 19:04:13 -0800 [thread overview]
Message-ID: <20240130030413.2031009-1-matthew.brost@intel.com> (raw)
Rather then loop over entities until one with a ready job is found,
re-queue the run job worker when drm_sched_entity_pop_job() returns NULL.
Fixes: 6dbd9004a55 ("drm/sched: Drain all entities in DRM sched run job worker")
Signed-off-by: Matthew Brost <matthew.brost@intel.com>
---
drivers/gpu/drm/scheduler/sched_main.c | 15 +++++++++------
1 file changed, 9 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/scheduler/sched_main.c b/drivers/gpu/drm/scheduler/sched_main.c
index 8acbef7ae53d..7e90c9f95611 100644
--- a/drivers/gpu/drm/scheduler/sched_main.c
+++ b/drivers/gpu/drm/scheduler/sched_main.c
@@ -1178,21 +1178,24 @@ static void drm_sched_run_job_work(struct work_struct *w)
struct drm_sched_entity *entity;
struct dma_fence *fence;
struct drm_sched_fence *s_fence;
- struct drm_sched_job *sched_job = NULL;
+ struct drm_sched_job *sched_job;
int r;
if (READ_ONCE(sched->pause_submit))
return;
/* Find entity with a ready job */
- while (!sched_job && (entity = drm_sched_select_entity(sched))) {
- sched_job = drm_sched_entity_pop_job(entity);
- if (!sched_job)
- complete_all(&entity->entity_idle);
- }
+ entity = drm_sched_select_entity(sched);
if (!entity)
return; /* No more work */
+ sched_job = drm_sched_entity_pop_job(entity);
+ if (!sched_job) {
+ complete_all(&entity->entity_idle);
+ drm_sched_run_job_queue(sched);
+ return;
+ }
+
s_fence = sched_job->s_fence;
atomic_add(sched_job->credits, &sched->credit_count);
--
2.34.1
next reply other threads:[~2024-01-30 3:03 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-30 3:04 Matthew Brost [this message]
2024-01-30 3:07 ` ✓ CI.Patch_applied: success for drm/sched: Re-queue run job worker when drm_sched_entity_pop_job() returns NULL Patchwork
2024-01-30 3:07 ` ✗ CI.checkpatch: warning " Patchwork
2024-01-30 3:08 ` ✓ CI.KUnit: success " Patchwork
2024-01-30 3:15 ` ✓ CI.Build: " Patchwork
2024-01-30 3:15 ` ✓ CI.Hooks: " Patchwork
2024-01-30 3:17 ` ✓ CI.checksparse: " Patchwork
2024-01-30 3:39 ` ✓ CI.BAT: " Patchwork
2024-01-30 7:05 ` [PATCH] " Christian König
2024-02-02 21:58 ` Rodrigo Vivi
2024-02-05 8:44 ` Christian König
2024-02-05 13:33 ` Rodrigo Vivi
2024-02-06 0:56 ` Luben Tuikov
2024-02-06 2:05 ` Dave Airlie
2024-02-06 0:45 ` Luben Tuikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240130030413.2031009-1-matthew.brost@intel.com \
--to=matthew.brost@intel.com \
--cc=airlied@gmail.com \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=ltuikov89@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox