From: Janusz Krzysztofik <janusz.krzysztofik@linux.intel.com>
To: igt-dev@lists.freedesktop.org
Cc: intel-xe@lists.freedesktop.org,
Kamil Konieczny <kamil.konieczny@linux.intel.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Lucas De Marchi <lucas.demarchi@intel.com>,
Janusz Krzysztofik <janusz.krzysztofik@linux.intel.com>
Subject: [PATCH i-g-t v3 5/6] lib/kunit: Report early kernel taints explicitly
Date: Thu, 1 Feb 2024 19:59:21 +0100 [thread overview]
Message-ID: <20240201190237.150754-13-janusz.krzysztofik@linux.intel.com> (raw)
In-Reply-To: <20240201190237.150754-8-janusz.krzysztofik@linux.intel.com>
When we find the kernel tainted after loading a KUnit test module in
list only mode, report that taint immediately as the reason for skip
instead of executing and blaming our KTAP parser.
Signed-off-by: Janusz Krzysztofik <janusz.krzysztofik@linux.intel.com>
Reviewed-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>
---
lib/igt_kmod.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/lib/igt_kmod.c b/lib/igt_kmod.c
index 83416d2aa4..0ac4ac7a02 100644
--- a/lib/igt_kmod.c
+++ b/lib/igt_kmod.c
@@ -1146,6 +1146,7 @@ static void kunit_get_tests(struct igt_list_head *tests,
char *suite_name = NULL, *case_name = NULL;
struct igt_ktap_result *r, *rn;
struct igt_ktap_results *ktap;
+ unsigned long taints;
int flags, err;
igt_skip_on_f(tst->kmsg < 0, "Could not open /dev/kmsg\n");
@@ -1181,6 +1182,7 @@ static void kunit_get_tests(struct igt_list_head *tests,
}
igt_skip_on(modprobe(tst->kmod, opts));
+ igt_skip_on(igt_kernel_tainted(&taints));
ktap = igt_ktap_alloc(tests);
igt_require(ktap);
--
2.43.0
next prev parent reply other threads:[~2024-02-01 19:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-01 18:59 [PATCH i-g-t v3 0/6] lib/kunit: Support writable filter* parameters of kunit module Janusz Krzysztofik
2024-02-01 18:59 ` [PATCH i-g-t v3 1/6] lib/kunit: Skip on empty list of test cases Janusz Krzysztofik
2024-02-01 18:59 ` [PATCH i-g-t v3 2/6] lib/kmode: Prepare open_parameters() helper for reuse by kunit Janusz Krzysztofik
2024-02-01 18:59 ` [PATCH i-g-t v3 3/6] lib/kunit: Unload base KUnit module only before reloading it Janusz Krzysztofik
2024-02-02 10:37 ` Kamil Konieczny
2024-02-01 18:59 ` [PATCH i-g-t v3 4/6] lib/kunit: Support writable filter* parameters of kunit module Janusz Krzysztofik
2024-02-01 20:26 ` Lucas De Marchi
2024-02-02 10:14 ` Janusz Krzysztofik
2024-02-02 15:57 ` Lucas De Marchi
2024-02-05 12:38 ` Janusz Krzysztofik
2024-02-01 18:59 ` Janusz Krzysztofik [this message]
2024-02-01 18:59 ` [PATCH i-g-t v3 6/6] lib/kunit: Process module remove error after list errors Janusz Krzysztofik
2024-02-01 20:55 ` ✗ CI.Patch_applied: failure for lib/kunit: Support writable filter* parameters of kunit module (rev3) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240201190237.150754-13-janusz.krzysztofik@linux.intel.com \
--to=janusz.krzysztofik@linux.intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=kamil.konieczny@linux.intel.com \
--cc=lucas.demarchi@intel.com \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox